You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/05/27 21:14:00 UTC
[jira] [Commented] (GEODE-8194) Refactor Result object into
`geode-common` for usage in other modules
[ https://issues.apache.org/jira/browse/GEODE-8194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118101#comment-17118101 ]
ASF GitHub Bot commented on GEODE-8194:
---------------------------------------
yozaner1324 opened a new pull request #5171:
URL: https://github.com/apache/geode/pull/5171
…r modules.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Refactor Result object into `geode-common` for usage in other modules
> ---------------------------------------------------------------------
>
> Key: GEODE-8194
> URL: https://issues.apache.org/jira/browse/GEODE-8194
> Project: Geode
> Issue Type: Improvement
> Reporter: Udo Kohlmeyer
> Assignee: Patrick Johnsn
> Priority: Major
>
> In the Protobuf serialization mechanism, the notion of a Result type was introduced. This type would represent either the success or Failure of a service call. This helped in handling error and success responses in single contextual location.
> Moving this into `geode-common` will aid in the usage of it in the `geode-modules` (class loader isolation effort)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)