You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/11/18 09:31:07 UTC
[Impala-ASF-CR] IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14734
Change subject: IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
......................................................................
IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
When checking privilege requests, we put table level request before
column level requests in the request list. If a table has both row
filter policy and column masking policies, the error message will be row
filtering not supported. So we need to clear any existing row filter
policies in AuthorizationStmtTest#testColumnMaskEnabled().
Test:
Manually create some row filter policies and run testColumnMaskEnabled
successfully.
Change-Id: Ic77fc7480e1b8bc8abcc3968f11ee148c1f02c0f
---
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java
2 files changed, 34 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/14734/1
--
To view, visit http://gerrit.cloudera.org:8080/14734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic77fc7480e1b8bc8abcc3968f11ee148c1f02c0f
Gerrit-Change-Number: 14734
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14734 )
Change subject: IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77fc7480e1b8bc8abcc3968f11ee148c1f02c0f
Gerrit-Change-Number: 14734
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 17:17:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14734 )
Change subject: IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
......................................................................
Patch Set 1: Code-Review+2
I would prefer to investigate why the row filter policies are still there, but I am ok with the current solution to deflake tests for now.
--
To view, visit http://gerrit.cloudera.org:8080/14734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77fc7480e1b8bc8abcc3968f11ee148c1f02c0f
Gerrit-Change-Number: 14734
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 17:13:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14734 )
Change subject: IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77fc7480e1b8bc8abcc3968f11ee148c1f02c0f
Gerrit-Change-Number: 14734
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 22:31:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14734 )
Change subject: IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
......................................................................
Patch Set 1:
Passed pre-review test: https://jenkins.impala.io/job/pre-review-test/452/
--
To view, visit http://gerrit.cloudera.org:8080/14734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77fc7480e1b8bc8abcc3968f11ee148c1f02c0f
Gerrit-Change-Number: 14734
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 00:53:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14734 )
Change subject: IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
......................................................................
IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
When checking privilege requests, we put table level request before
column level requests in the request list. If a table has both row
filter policy and column masking policies, the error message will be row
filtering not supported. So we need to clear any existing row filter
policies in AuthorizationStmtTest#testColumnMaskEnabled().
Test:
Manually create some row filter policies and run testColumnMaskEnabled
successfully.
Change-Id: Ic77fc7480e1b8bc8abcc3968f11ee148c1f02c0f
Reviewed-on: http://gerrit.cloudera.org:8080/14734
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java
2 files changed, 34 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic77fc7480e1b8bc8abcc3968f11ee148c1f02c0f
Gerrit-Change-Number: 14734
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14734 )
Change subject: IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5257/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77fc7480e1b8bc8abcc3968f11ee148c1f02c0f
Gerrit-Change-Number: 14734
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 17:17:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14734 )
Change subject: IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5046/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77fc7480e1b8bc8abcc3968f11ee148c1f02c0f
Gerrit-Change-Number: 14734
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Nov 2019 10:15:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14734 )
Change subject: IMPALA-9152: Clear row filter policies before testColumnMaskEnabled
......................................................................
Patch Set 1: Code-Review+1
Change looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/14734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77fc7480e1b8bc8abcc3968f11ee148c1f02c0f
Gerrit-Change-Number: 14734
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 07:01:33 +0000
Gerrit-HasComments: No