You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/15 19:20:04 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #6686: Minor: consolidate datafusion_substrait tests into `substrait_integration` to save builder space and build time #6685
alamb opened a new pull request, #6686:
URL: https://github.com/apache/arrow-datafusion/pull/6686
# Which issue does this PR close?
Part of https://github.com/apache/arrow-datafusion/pull/6682
# Rationale for this change
This is the same pattern applied in https://github.com/apache/arrow-datafusion/pull/6682
Basically, each test binary has about 125MB of overhead (the size of the datafusion code that is linked in). Thus I estimate this PR to save 2 * ~125 MB of builder space as it reduces the number of test binaries created by 2
# What changes are included in this PR?
consolidate repartition test into `substrait_integration` to save builder space and build time
# Are these changes tested?
Yes
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6686: Minor: consolidate datafusion_substrait tests into `substrait_integration` to save builder space and build time #6685
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6686:
URL: https://github.com/apache/arrow-datafusion/pull/6686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6686: Minor: consolidate datafusion_substrait tests into `substrait_integration` to save builder space and build time #6685
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6686:
URL: https://github.com/apache/arrow-datafusion/pull/6686#discussion_r1231444266
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -0,0 +1,697 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I moved these files and then removed a level of indenting. I did not change any of the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6686: Minor: consolidate datafusion_substrait tests into `substrait_integration` to save builder space and build time #6685
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6686:
URL: https://github.com/apache/arrow-datafusion/pull/6686#discussion_r1231444266
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -0,0 +1,697 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I moved these files and then removed a level of indenting as
```rust
#[cfg(test)]
mod tests {
```
is not necessary for integration tests
. I did not change any of the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org