You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Brian Towles via Review Board <no...@reviews.apache.org> on 2018/08/23 16:41:32 UTC
Review Request 68488: SENTRY-2367: Implement subsystem to allow for
pluggable attribute providers and transports
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/
-----------------------------------------------------------
Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
Bugs: SENTRY-2367
https://issues.apache.org/jira/browse/SENTRY-2367
Repository: sentry
Description
-------
Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
instances of Service defined.
Currently stand alone module. Will be built used by ABCM in future commits.
Diffs
-----
lombok.config PRE-CREATION
pom.xml dcf107680c3b395819043136bcc6e179a60ada35
sentry-dist/src/license/THIRD-PARTY.properties a1084db6962cefb2a710cc3871de6c1c083892ce
sentry-spi/pom.xml PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
Diff: https://reviews.apache.org/r/68488/diff/1/
Testing
-------
Unit tests.
Thanks,
Brian Towles
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
> On Aug. 27, 2018, 8:32 p.m., Steve Moist wrote:
> > pom.xml
> > Lines 410 (patched)
> > <https://reviews.apache.org/r/68488/diff/2/?file=2076863#file2076863line410>
> >
> > Why is this provided?
>
> Brian Towles wrote:
> Lombok only hooks on the compile and modified the output classes directly. You dont need to actually include it in the distrobution.
>
> Steve Moist wrote:
> Should it be scope compile then?
>
> Brian Towles wrote:
> No Compile scope includes it in the transative dependencies. Provided make it available for compile but does not include in transative dependencies.
Cool, I'm good on this change then.
- Steve
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review207990
-----------------------------------------------------------
On Aug. 31, 2018, 4:03 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 4:03 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> pom.xml fb9950d0feca18f7f49531c6c38bb7357b565e5b
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/3/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
> On Aug. 27, 2018, 3:32 p.m., Steve Moist wrote:
> > pom.xml
> > Lines 410 (patched)
> > <https://reviews.apache.org/r/68488/diff/2/?file=2076863#file2076863line410>
> >
> > Why is this provided?
>
> Brian Towles wrote:
> Lombok only hooks on the compile and modified the output classes directly. You dont need to actually include it in the distrobution.
>
> Steve Moist wrote:
> Should it be scope compile then?
No Compile scope includes it in the transative dependencies. Provided make it available for compile but does not include in transative dependencies.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review207990
-----------------------------------------------------------
On Aug. 31, 2018, 11:03 a.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 11:03 a.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> pom.xml fb9950d0feca18f7f49531c6c38bb7357b565e5b
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/3/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
> On Aug. 27, 2018, 8:32 p.m., Steve Moist wrote:
> > pom.xml
> > Lines 410 (patched)
> > <https://reviews.apache.org/r/68488/diff/2/?file=2076863#file2076863line410>
> >
> > Why is this provided?
>
> Brian Towles wrote:
> Lombok only hooks on the compile and modified the output classes directly. You dont need to actually include it in the distrobution.
Should it be scope compile then?
- Steve
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review207990
-----------------------------------------------------------
On Aug. 24, 2018, 1:15 a.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 1:15 a.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml dcf107680c3b395819043136bcc6e179a60ada35
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/2/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
> On Aug. 27, 2018, 3:32 p.m., Steve Moist wrote:
> > pom.xml
> > Lines 410 (patched)
> > <https://reviews.apache.org/r/68488/diff/2/?file=2076863#file2076863line410>
> >
> > Why is this provided?
Lombok only hooks on the compile and modified the output classes directly. You dont need to actually include it in the distrobution.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review207990
-----------------------------------------------------------
On Aug. 23, 2018, 8:15 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 8:15 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml dcf107680c3b395819043136bcc6e179a60ada35
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/2/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review207990
-----------------------------------------------------------
pom.xml
Lines 410 (patched)
<https://reviews.apache.org/r/68488/#comment291713>
Why is this provided?
sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java
Lines 23 (patched)
<https://reviews.apache.org/r/68488/#comment291708>
Add a class description
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java
Lines 23 (patched)
<https://reviews.apache.org/r/68488/#comment291709>
Add to comment or remove.
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java
Lines 23 (patched)
<https://reviews.apache.org/r/68488/#comment291710>
Add to comment or remove.
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java
Lines 23 (patched)
<https://reviews.apache.org/r/68488/#comment291711>
Add to comment or remove.
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java
Lines 23 (patched)
<https://reviews.apache.org/r/68488/#comment291712>
Add to comment or remove.
- Steve Moist
On Aug. 24, 2018, 1:15 a.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 1:15 a.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml dcf107680c3b395819043136bcc6e179a60ada35
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/2/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
> On Aug. 23, 2018, 8:54 p.m., Alexander Kolbasov wrote:
> > sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java
> > Lines 27 (patched)
> > <https://reviews.apache.org/r/68488/diff/2/?file=2076865#file2076865line27>
> >
> > What is this file - where does it come from?
Derived from the Keycloak SPI Implementaion (https://github.com/keycloak/keycloak/blob/4.3.0.Final/services/src/main/java/org/keycloak/provider/DefaultProviderLoader.java) which is under an Apache 2.0 License with author attribution left in place.
> On Aug. 23, 2018, 8:54 p.m., Alexander Kolbasov wrote:
> > sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java
> > Lines 23 (patched)
> > <https://reviews.apache.org/r/68488/diff/2/?file=2076866#file2076866line23>
> >
> > Where does this file come from?
Derived from the Keycloak SPI Implementaion (https://github.com/keycloak/keycloak/blob/4.3.0.Final/server-spi/src/main/java/org/keycloak/provider/Provider.java) which is under an Apache 2.0 License with author attribution left in place.
> On Aug. 23, 2018, 8:54 p.m., Alexander Kolbasov wrote:
> > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java
> > Lines 25 (patched)
> > <https://reviews.apache.org/r/68488/diff/2/?file=2076867#file2076867line25>
> >
> > where ddoes this file come from?
Derived from the Keycloak SPI Implementaion (https://github.com/keycloak/keycloak/blob/4.3.0.Final/server-spi/src/main/java/org/keycloak/provider/ProviderFactory.java) which is under an Apache 2.0 License with author attribution left in place.
> On Aug. 23, 2018, 8:54 p.m., Alexander Kolbasov wrote:
> > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java
> > Lines 34 (patched)
> > <https://reviews.apache.org/r/68488/diff/2/?file=2076869#file2076869line34>
> >
> > Typo? "Provider manager *what*"
Yeah typo. will clean up
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review207847
-----------------------------------------------------------
On Aug. 23, 2018, 8:15 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 8:15 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml dcf107680c3b395819043136bcc6e179a60ada35
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/2/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review207847
-----------------------------------------------------------
sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java
Lines 27 (patched)
<https://reviews.apache.org/r/68488/#comment291380>
What is this file - where does it come from?
sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java
Lines 23 (patched)
<https://reviews.apache.org/r/68488/#comment291381>
Where does this file come from?
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java
Lines 25 (patched)
<https://reviews.apache.org/r/68488/#comment291382>
where ddoes this file come from?
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java
Lines 34 (patched)
<https://reviews.apache.org/r/68488/#comment291383>
Typo? "Provider manager *what*"
sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java
Lines 24 (patched)
<https://reviews.apache.org/r/68488/#comment291384>
Is this file coming from somewhere?
- Alexander Kolbasov
On Aug. 24, 2018, 1:15 a.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 1:15 a.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml dcf107680c3b395819043136bcc6e179a60ada35
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/2/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
> On Aug. 29, 2018, 3:29 p.m., Steve Moist wrote:
> > lombok.config
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/68488/diff/2/?file=2076862#file2076862line1>
> >
> > In introducing lombok into sentry. Will the configs for the existing sl4j need to be updated or modified?
> >
> > I would recommend that we move this lombok change into a seperate changeset. I would want all of Sentry to be consistant with it's logging mechanism.
>
> Alexander Kolbasov wrote:
> Agreed - it is always better not to mix two independent changes together.
>
> Brian Towles wrote:
> This doesnt change anything to do with the logs or logging. This is simply the name of the variable that lombok creates when it sets up the static logger instance in the class annotated with @Slf4j.
I split this into a seperate subtask (SENTRY-2374) and review (https://reviews.apache.org/r/68585/)
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review208112
-----------------------------------------------------------
On Aug. 23, 2018, 8:15 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 8:15 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml dcf107680c3b395819043136bcc6e179a60ada35
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/2/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On Aug. 29, 2018, 8:29 p.m., Steve Moist wrote:
> > lombok.config
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/68488/diff/2/?file=2076862#file2076862line1>
> >
> > In introducing lombok into sentry. Will the configs for the existing sl4j need to be updated or modified?
> >
> > I would recommend that we move this lombok change into a seperate changeset. I would want all of Sentry to be consistant with it's logging mechanism.
Agreed - it is always better not to mix two independent changes together.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review208112
-----------------------------------------------------------
On Aug. 24, 2018, 1:15 a.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 1:15 a.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml dcf107680c3b395819043136bcc6e179a60ada35
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/2/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
> On Aug. 29, 2018, 3:29 p.m., Steve Moist wrote:
> > lombok.config
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/68488/diff/2/?file=2076862#file2076862line1>
> >
> > In introducing lombok into sentry. Will the configs for the existing sl4j need to be updated or modified?
> >
> > I would recommend that we move this lombok change into a seperate changeset. I would want all of Sentry to be consistant with it's logging mechanism.
>
> Alexander Kolbasov wrote:
> Agreed - it is always better not to mix two independent changes together.
This doesnt change anything to do with the logs or logging. This is simply the name of the variable that lombok creates when it sets up the static logger instance in the class annotated with @Slf4j.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review208112
-----------------------------------------------------------
On Aug. 23, 2018, 8:15 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 8:15 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml dcf107680c3b395819043136bcc6e179a60ada35
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/2/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review208112
-----------------------------------------------------------
lombok.config
Lines 1 (patched)
<https://reviews.apache.org/r/68488/#comment291893>
In introducing lombok into sentry. Will the configs for the existing sl4j need to be updated or modified?
I would recommend that we move this lombok change into a seperate changeset. I would want all of Sentry to be consistant with it's logging mechanism.
- Steve Moist
On Aug. 24, 2018, 1:15 a.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 1:15 a.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml dcf107680c3b395819043136bcc6e179a60ada35
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/2/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review208318
-----------------------------------------------------------
Ship it!
Ship It!
- Steve Moist
On Aug. 31, 2018, 4:03 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 4:03 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> pom.xml fb9950d0feca18f7f49531c6c38bb7357b565e5b
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/3/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review208463
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Aug. 31, 2018, 4:03 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 4:03 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> pom.xml fb9950d0feca18f7f49531c6c38bb7357b565e5b
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/3/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review208179
-----------------------------------------------------------
sentry-spi/pom.xml
Lines 45 (patched)
<https://reviews.apache.org/r/68488/#comment291952>
Sorry if I wasnt' clear. For SENTRY-2374 add all of the lombock changes into there and use the existing loggers for now.
- Steve Moist
On Aug. 31, 2018, 4:03 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 4:03 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by MDCM in future commits.
>
>
> Diffs
> -----
>
> pom.xml fb9950d0feca18f7f49531c6c38bb7357b565e5b
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/3/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/
-----------------------------------------------------------
(Updated Aug. 31, 2018, 11:03 a.m.)
Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
Bugs: SENTRY-2367
https://issues.apache.org/jira/browse/SENTRY-2367
Repository: sentry
Description
-------
Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
instances of Service defined.
Currently stand alone module. Will be built used by MDCM in future commits.
Diffs (updated)
-----
pom.xml fb9950d0feca18f7f49531c6c38bb7357b565e5b
sentry-spi/pom.xml PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
Diff: https://reviews.apache.org/r/68488/diff/3/
Changes: https://reviews.apache.org/r/68488/diff/2-3/
Testing
-------
Unit tests.
Thanks,
Brian Towles
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/
-----------------------------------------------------------
(Updated Aug. 23, 2018, 8:15 p.m.)
Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
Bugs: SENTRY-2367
https://issues.apache.org/jira/browse/SENTRY-2367
Repository: sentry
Description (updated)
-------
Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
instances of Service defined.
Currently stand alone module. Will be built used by MDCM in future commits.
Diffs
-----
lombok.config PRE-CREATION
pom.xml dcf107680c3b395819043136bcc6e179a60ada35
sentry-spi/pom.xml PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
Diff: https://reviews.apache.org/r/68488/diff/2/
Testing
-------
Unit tests.
Thanks,
Brian Towles
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/
-----------------------------------------------------------
(Updated Aug. 23, 2018, 3:26 p.m.)
Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
Changes
-------
removed changed sentry-dist/src/license/THIRD-PARTY.properties
Bugs: SENTRY-2367
https://issues.apache.org/jira/browse/SENTRY-2367
Repository: sentry
Description
-------
Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
instances of Service defined.
Currently stand alone module. Will be built used by ABCM in future commits.
Diffs (updated)
-----
lombok.config PRE-CREATION
pom.xml dcf107680c3b395819043136bcc6e179a60ada35
sentry-spi/pom.xml PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
Diff: https://reviews.apache.org/r/68488/diff/2/
Changes: https://reviews.apache.org/r/68488/diff/1-2/
Testing
-------
Unit tests.
Thanks,
Brian Towles
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
> On Aug. 23, 2018, 1:48 p.m., Na Li wrote:
> > sentry-dist/src/license/THIRD-PARTY.properties
> > Line 32 (original), 32 (patched)
> > <https://reviews.apache.org/r/68488/diff/1/?file=2076572#file2076572line32>
> >
> > do we need to commit this file?
Nope didnt mean to, will pull from patch
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review207825
-----------------------------------------------------------
On Aug. 23, 2018, 11:41 a.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 11:41 a.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by ABCM in future commits.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml dcf107680c3b395819043136bcc6e179a60ada35
> sentry-dist/src/license/THIRD-PARTY.properties a1084db6962cefb2a710cc3871de6c1c083892ce
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/1/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow
for pluggable attribute providers and transports
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review207825
-----------------------------------------------------------
sentry-dist/src/license/THIRD-PARTY.properties
Line 32 (original), 32 (patched)
<https://reviews.apache.org/r/68488/#comment291353>
do we need to commit this file?
- Na Li
On Aug. 23, 2018, 4:41 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 4:41 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2367
> https://issues.apache.org/jira/browse/SENTRY-2367
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic implementation of the Java SPI. Abstracted to provide Factory configuration for
> instances of Service defined.
>
> Currently stand alone module. Will be built used by ABCM in future commits.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml dcf107680c3b395819043136bcc6e179a60ada35
> sentry-dist/src/license/THIRD-PARTY.properties a1084db6962cefb2a710cc3871de6c1c083892ce
> sentry-spi/pom.xml PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION
> sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java PRE-CREATION
> sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory PRE-CREATION
> sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68488/diff/1/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>