You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2024/05/28 22:57:21 UTC
[PR] chore: bump python 'holidays' lib from 0.25 to 0.49 [superset]
mistercrunch opened a new pull request, #28747:
URL: https://github.com/apache/superset/pull/28747
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: bump python 'holidays' lib from 0.25 to 0.49 [superset]
Posted by "request-info[bot] (via GitHub)" <gi...@apache.org>.
request-info[bot] commented on PR #28747:
URL: https://github.com/apache/superset/pull/28747#issuecomment-2136238678
We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the `title` or `description` empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: bump python 'holidays' lib from 0.25 to 0.49 [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #28747:
URL: https://github.com/apache/superset/pull/28747#issuecomment-2138090222
@john-bodley great catch! I totally would have missed that. I think we really need to add comments for all real upper bounds in pyroject.toml, including if it's just "based on semantic versioning and/or stress levels around this specific dependency".
I'm planning on implementing something like `supersetbot bump-python --disregard-upper-bound` which would do as specified and remove the upper bound in the process. We may need more parsable hints as smart comments so that @supersetbot knows what to do with it say:
```
"holidays>=0.25, <0.26", #known-upper-bound-issue #couple-with-lib=prophet
```
or something like
```
"holidays>=0.25, <1", #semver-upper-bound
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: bump python 'holidays' lib from 0.25 to 0.49 [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on code in PR #28747:
URL: https://github.com/apache/superset/pull/28747#discussion_r1619246857
##########
pyproject.toml:
##########
@@ -57,7 +57,7 @@ dependencies = [
"geopy",
"gunicorn>=22.0.0; sys_platform != 'win32'",
"hashids>=1.3.1, <2",
- "holidays>=0.25, <0.26",
+ "holidays>=0.25",
Review Comment:
Should we bump the lower bound and also place an upper bound of `1.0.0` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: bump python 'holidays' lib from 0.25 to 0.49 [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on code in PR #28747:
URL: https://github.com/apache/superset/pull/28747#discussion_r1619246857
##########
pyproject.toml:
##########
@@ -57,7 +57,7 @@ dependencies = [
"geopy",
"gunicorn>=22.0.0; sys_platform != 'win32'",
"hashids>=1.3.1, <2",
- "holidays>=0.25, <0.26",
+ "holidays>=0.25",
Review Comment:
Should we place an upper bound of `1.0.0` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: bump python 'holidays' lib from 0.25 to 0.49 [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #28747:
URL: https://github.com/apache/superset/pull/28747#issuecomment-2137927167
@mistercrunch it would be good to determine if the issue in https://github.com/apache/superset/pull/25017 has been resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: document upper bound for python lib 'holidays' >= 0.26 [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #28747:
URL: https://github.com/apache/superset/pull/28747#issuecomment-2360092000
@rusackas closing/cleaning some old PRs if you don't mind stamping this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org