[jira] [Commented] (AIRFLOW-5532) Missed imagePullSecrets from pod created from k8s executor

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935195#comment-16935195 ] 

ASF GitHub Bot commented on AIRFLOW-5532:
-----------------------------------------

shawnzhu commented on pull request #6166: [AIRFLOW-5532] Fix imagePullSecrets in pod created from k8s executor
URL: https://github.com/apache/airflow/pull/6166
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5532
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
      bug fix for supporting pulling private container image.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
      `tests.kubernetes.TestKubernetesWorkerConfiguration.test_make_pod_with_image_pull_secrets()`
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Missed imagePullSecrets from pod created from k8s executor
> ----------------------------------------------------------
>
>                 Key: AIRFLOW-5532
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5532
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: executor-kubernetes
>    Affects Versions: 2.0.0
>         Environment: container image apache/airflow:master-python3.7-ci-slim which appears to be v2.0.0-dev 
>            Reporter: Ke Zhu
>            Assignee: Daniel Imberman
>            Priority: Major
>
> I used container image built based on *apache/airflow:master-python3.7-ci-slim* with k8s executor configured in airflow.cfg. all config options under section [kubernetes] and [kubernetes_secrets] are recognized successfully except option _image_pull_secrets_. 
>  
> Then I inspected the code at [https://github.com/apache/airflow/blob/47801057989046dfcf7b424ce54afee103803815/airflow/kubernetes/worker_configuration.py#L367-L387] where {{image_pull_secrets}} is NOT specified at all when constructing an object of {{PodGenerator}}. When reviewing further, I've noticed that the method {{WorkerConfiguration._get_image_pull_secrets()}} is not used at all. Which should be used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)