You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2009/04/05 19:36:12 UTC
[jira] Created: (MATH-257)
FastFourierTransformer.MultiDimensionalComplexMatrix.get() not consistent
with FastFourierTransformer.MultiDimensionalComplexMatrix.set()
FastFourierTransformer.MultiDimensionalComplexMatrix.get() not consistent with FastFourierTransformer.MultiDimensionalComplexMatrix.set()
-----------------------------------------------------------------------------------------------------------------------------------------
Key: MATH-257
URL: https://issues.apache.org/jira/browse/MATH-257
Project: Commons Math
Issue Type: Bug
Reporter: Sebb
FastFourierTransformer.MultiDimensionalComplexMatrix.get() is not consistent with FastFourierTransformer.MultiDimensionalComplexMatrix.set().
The set() method does not allow a null parameter to get past the first check.
The get() method allows a null parameter provided dimensionSize.length <= 1.
This seems wrong, both because it is inconsistent and because it may allow an NPE later if dimensionSize.length == 1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MATH-257)
FastFourierTransformer.MultiDimensionalComplexMatrix.get() not consistent
with FastFourierTransformer.MultiDimensionalComplexMatrix.set()
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated MATH-257:
----------------------
Fix Version/s: 2.0
> FastFourierTransformer.MultiDimensionalComplexMatrix.get() not consistent with FastFourierTransformer.MultiDimensionalComplexMatrix.set()
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MATH-257
> URL: https://issues.apache.org/jira/browse/MATH-257
> Project: Commons Math
> Issue Type: Bug
> Reporter: Sebb
> Assignee: Luc Maisonobe
> Fix For: 2.0
>
>
> FastFourierTransformer.MultiDimensionalComplexMatrix.get() is not consistent with FastFourierTransformer.MultiDimensionalComplexMatrix.set().
> The set() method does not allow a null parameter to get past the first check.
> The get() method allows a null parameter provided dimensionSize.length <= 1.
> This seems wrong, both because it is inconsistent and because it may allow an NPE later if dimensionSize.length == 1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MATH-257)
FastFourierTransformer.MultiDimensionalComplexMatrix.get() not consistent
with FastFourierTransformer.MultiDimensionalComplexMatrix.set()
Posted by "Luc Maisonobe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luc Maisonobe resolved MATH-257.
--------------------------------
Resolution: Fixed
Assignee: Luc Maisonobe
fixed in subversion repository as of r762131.
I took the opportunity to also simplify the initialization of the dimensionSize array, using a two passes algorithm.
The inconsistency by itself was removed by having bot set and get be no-op for null vectors
> FastFourierTransformer.MultiDimensionalComplexMatrix.get() not consistent with FastFourierTransformer.MultiDimensionalComplexMatrix.set()
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MATH-257
> URL: https://issues.apache.org/jira/browse/MATH-257
> Project: Commons Math
> Issue Type: Bug
> Reporter: Sebb
> Assignee: Luc Maisonobe
>
> FastFourierTransformer.MultiDimensionalComplexMatrix.get() is not consistent with FastFourierTransformer.MultiDimensionalComplexMatrix.set().
> The set() method does not allow a null parameter to get past the first check.
> The get() method allows a null parameter provided dimensionSize.length <= 1.
> This seems wrong, both because it is inconsistent and because it may allow an NPE later if dimensionSize.length == 1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.