You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2022/05/06 09:20:45 UTC

[incubator-doris] 06/11: [Bug] [Build] fix clang build fail (#9323)

This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git

commit f4bdeeebac3d73fa806d8842b0c9995f64e6f5b0
Author: Pxl <95...@qq.com>
AuthorDate: Mon May 2 18:04:57 2022 +0800

    [Bug] [Build] fix clang build fail (#9323)
    
    * fix clang compile fail
---
 be/src/exec/broker_scan_node.h | 20 ++++++++++++--------
 be/src/exec/broker_scanner.h   |  2 +-
 2 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/be/src/exec/broker_scan_node.h b/be/src/exec/broker_scan_node.h
index c4494731d8..ffabda7d0b 100644
--- a/be/src/exec/broker_scan_node.h
+++ b/be/src/exec/broker_scan_node.h
@@ -41,29 +41,33 @@ struct ScannerCounter;
 class BrokerScanNode : public ScanNode {
 public:
     BrokerScanNode(ObjectPool* pool, const TPlanNode& tnode, const DescriptorTbl& descs);
-    virtual ~BrokerScanNode();
+    ~BrokerScanNode() override;
 
     // Called after create this scan node
-    virtual Status init(const TPlanNode& tnode, RuntimeState* state = nullptr) override;
+    Status init(const TPlanNode& tnode, RuntimeState* state = nullptr) override;
 
     // Prepare partition infos & set up timer
-    virtual Status prepare(RuntimeState* state) override;
+    Status prepare(RuntimeState* state) override;
 
     // Start broker scan using ParquetScanner or BrokerScanner.
-    virtual Status open(RuntimeState* state) override;
+    Status open(RuntimeState* state) override;
 
     // Fill the next row batch by calling next() on the scanner,
-    virtual Status get_next(RuntimeState* state, RowBatch* row_batch, bool* eos) override;
+    Status get_next(RuntimeState* state, RowBatch* row_batch, bool* eos) override;
+
+    Status get_next(RuntimeState* state, vectorized::Block* block, bool* eos) override {
+        return Status::NotSupported("Not Implemented get block");
+    }
 
     // Close the scanner, and report errors.
-    virtual Status close(RuntimeState* state) override;
+    Status close(RuntimeState* state) override;
 
     // No use
-    virtual Status set_scan_ranges(const std::vector<TScanRangeParams>& scan_ranges) override;
+    Status set_scan_ranges(const std::vector<TScanRangeParams>& scan_ranges) override;
 
 protected:
     // Write debug string of this into out.
-    virtual void debug_string(int indentation_level, std::stringstream* out) const override;
+    void debug_string(int indentation_level, std::stringstream* out) const override;
 
 private:
     // Update process status to one failed status,
diff --git a/be/src/exec/broker_scanner.h b/be/src/exec/broker_scanner.h
index ddd8bd9c78..7bc194f289 100644
--- a/be/src/exec/broker_scanner.h
+++ b/be/src/exec/broker_scanner.h
@@ -57,7 +57,7 @@ public:
                   const TBrokerScanRangeParams& params, const std::vector<TBrokerRangeDesc>& ranges,
                   const std::vector<TNetworkAddress>& broker_addresses,
                   const std::vector<TExpr>& pre_filter_texprs, ScannerCounter* counter);
-    ~BrokerScanner();
+    ~BrokerScanner() override;
 
     // Open this scanner, will initialize information need to
     Status open() override;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org