You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/20 14:11:37 UTC
[GitHub] [kafka] ijuma opened a new pull request #11094: MINOR: Improve usage of LogManager.currentDefaultConfig
ijuma opened a new pull request #11094:
URL: https://github.com/apache/kafka/pull/11094
In `deleteLogs`, we use a consistent value for `fileDeleteDelayMs`
for the whole method. In `DynamicBrokerConfig.reconfigure`, it's
a minor readability improvement, but there should be no change in
behavior.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11094: MINOR: Improve usage of LogManager.currentDefaultConfig
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11094:
URL: https://github.com/apache/kafka/pull/11094#issuecomment-884178111
Test failure is unrelated: kafka.api.ConsumerBounceTest.testCloseDuringRebalance()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #11094: MINOR: Improve usage of LogManager.currentDefaultConfig
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #11094:
URL: https://github.com/apache/kafka/pull/11094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11094: MINOR: Improve usage of LogManager.currentDefaultConfig
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11094:
URL: https://github.com/apache/kafka/pull/11094#issuecomment-883427114
@mumrah this is the follow-up we discussed in #10811.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org