You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Nobuaki Sukegawa (JIRA)" <ji...@apache.org> on 2015/04/11 19:07:12 UTC

[jira] [Created] (THRIFT-3091) c_glib service method should return result from handler method

Nobuaki Sukegawa created THRIFT-3091:
----------------------------------------

             Summary: c_glib service method should return result from handler method
                 Key: THRIFT-3091
                 URL: https://issues.apache.org/jira/browse/THRIFT-3091
             Project: Thrift
          Issue Type: Bug
          Components: C glib - Compiler
            Reporter: Nobuaki Sukegawa
             Fix For: 0.9.3


Generated c_glib service method has *gboolean* return type but actually returned nothing at all.

It seems that while gcc 4.9.2 treats it as if returning non-zero, clang 3.6.0 treats it as if returning zero.

The patch adds missing "return " to implementation(handler) method call in the last line of service method.

Note that it also includes style fix (0 -> FALSE) in the same line which is not essential.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)