You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/08 16:07:35 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34811: [SPARK-37451][SQL] Fix cast string type to decimal type if spark.sql.legacy.allowNegativeScaleOfDecimal is enabled
dongjoon-hyun commented on a change in pull request #34811:
URL: https://github.com/apache/spark/pull/34811#discussion_r765007003
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
##########
@@ -602,7 +602,8 @@ object Decimal {
val bigDecimal = stringToJavaBigDecimal(str)
// We fast fail because constructing a very large JavaBigDecimal to Decimal is very slow.
// For example: Decimal("6.0790316E+25569151")
- if (numDigitsInIntegralPart(bigDecimal) > DecimalType.MAX_PRECISION) {
+ if (numDigitsInIntegralPart(bigDecimal) > DecimalType.MAX_PRECISION &&
+ !SQLConf.get.allowNegativeScaleOfDecimalEnabled) {
Review comment:
indentation? We need two more spaces.
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
##########
@@ -618,7 +619,8 @@ object Decimal {
val bigDecimal = stringToJavaBigDecimal(str)
// We fast fail because constructing a very large JavaBigDecimal to Decimal is very slow.
// For example: Decimal("6.0790316E+25569151")
- if (numDigitsInIntegralPart(bigDecimal) > DecimalType.MAX_PRECISION) {
+ if (numDigitsInIntegralPart(bigDecimal) > DecimalType.MAX_PRECISION &&
+ !SQLConf.get.allowNegativeScaleOfDecimalEnabled) {
Review comment:
Indentation? We need two more spaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org