You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Narayan Periwal <na...@inmobi.com> on 2015/09/01 14:55:37 UTC
Review Request 38005: FALCON-1381: The webservice response of Falcon
includes a stack trace in case of errors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38005/
-----------------------------------------------------------
Review request for Falcon.
Repository: falcon-git
Description
-------
IMO, we should just return a good error message. The stack trace shouldn't really be the users concern.
Diffs
-----
prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
Diff: https://reviews.apache.org/r/38005/diff/
Testing
-------
Done
Thanks,
Narayan Periwal
Re: Review Request 38005: FALCON-1381: The webservice response of
Falcon includes a stack trace in case of errors
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Sept. 2, 2015, 6:28 a.m., Pallavi Rao wrote:
> > prism/src/main/java/org/apache/falcon/FalconWebException.java, line 104
> > <https://reviews.apache.org/r/38005/diff/2/?file=1062090#file1062090line104>
> >
> > Nit : Can we say "Caused By:" instead of just "\n"
>
> Narayan Periwal wrote:
> "\n" was used to separate the error message and the message due to the cause. I will add "Caused By" as well
Yep. That is what I meant "Caused By:\n"
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38005/#review97415
-----------------------------------------------------------
On Sept. 2, 2015, 6:24 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38005/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 6:24 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> IMO, we should just return a good error message. The stack trace shouldn't really be the users concern.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
>
> Diff: https://reviews.apache.org/r/38005/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38005: FALCON-1381: The webservice response of
Falcon includes a stack trace in case of errors
Posted by Narayan Periwal <na...@inmobi.com>.
> On Sept. 2, 2015, 6:28 a.m., Pallavi Rao wrote:
> > prism/src/main/java/org/apache/falcon/FalconWebException.java, line 104
> > <https://reviews.apache.org/r/38005/diff/2/?file=1062090#file1062090line104>
> >
> > Nit : Can we say "Caused By:" instead of just "\n"
"\n" was used to separate the error message and the message due to the cause. I will add "Caused By" as well
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38005/#review97415
-----------------------------------------------------------
On Sept. 2, 2015, 6:24 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38005/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 6:24 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> IMO, we should just return a good error message. The stack trace shouldn't really be the users concern.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
>
> Diff: https://reviews.apache.org/r/38005/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38005: FALCON-1381: The webservice response of
Falcon includes a stack trace in case of errors
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38005/#review97415
-----------------------------------------------------------
prism/src/main/java/org/apache/falcon/FalconWebException.java (line 102)
<https://reviews.apache.org/r/38005/#comment153297>
Nit : Can we say "Caused By:" instead of just "\n"
- Pallavi Rao
On Sept. 2, 2015, 6:24 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38005/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 6:24 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> IMO, we should just return a good error message. The stack trace shouldn't really be the users concern.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
>
> Diff: https://reviews.apache.org/r/38005/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38005: FALCON-1381: The webservice response of
Falcon includes a stack trace in case of errors
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38005/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 6:58 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
IMO, we should just return a good error message. The stack trace shouldn't really be the users concern.
Diffs (updated)
-----
prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
Diff: https://reviews.apache.org/r/38005/diff/
Testing
-------
Done
Thanks,
Narayan Periwal
Re: Review Request 38005: FALCON-1381: The webservice response of
Falcon includes a stack trace in case of errors
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38005/#review97416
-----------------------------------------------------------
Ship it!
See if you can address the minor nit. Patch is good, otherwise.
- Pallavi Rao
On Sept. 2, 2015, 6:24 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38005/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 6:24 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> IMO, we should just return a good error message. The stack trace shouldn't really be the users concern.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
>
> Diff: https://reviews.apache.org/r/38005/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38005: FALCON-1381: The webservice response of
Falcon includes a stack trace in case of errors
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38005/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 6:24 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
IMO, we should just return a good error message. The stack trace shouldn't really be the users concern.
Diffs (updated)
-----
prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
Diff: https://reviews.apache.org/r/38005/diff/
Testing
-------
Done
Thanks,
Narayan Periwal
Re: Review Request 38005: FALCON-1381: The webservice response of
Falcon includes a stack trace in case of errors
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38005/#review97285
-----------------------------------------------------------
Ship it!
- Balu Vellanki
On Sept. 1, 2015, 12:55 p.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38005/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 12:55 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> IMO, we should just return a good error message. The stack trace shouldn't really be the users concern.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
>
> Diff: https://reviews.apache.org/r/38005/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38005: FALCON-1381: The webservice response of
Falcon includes a stack trace in case of errors
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38005/#review97393
-----------------------------------------------------------
prism/src/main/java/org/apache/falcon/FalconWebException.java (line 103)
<https://reviews.apache.org/r/38005/#comment153283>
Why not just return e.getMessage()? Unnecessary construction of StringWriter().
Also, it would be good to add not just the message on the exception, but, the message from the cause.
- Pallavi Rao
On Sept. 1, 2015, 12:55 p.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38005/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 12:55 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> IMO, we should just return a good error message. The stack trace shouldn't really be the users concern.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
>
> Diff: https://reviews.apache.org/r/38005/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>