[GitHub] purplecabbage commented on issue #454: Use NSOperationQueue (GH-452)

[GitBox <gi...@apache.org>]

purplecabbage commented on issue #454: Use NSOperationQueue (GH-452)
URL: https://github.com/apache/cordova-ios/pull/454#issuecomment-441950183
 
 
   Thank you @ECNU3D 
   
   I like this change, however there are a few things I would like to see here. ( all subject to discussion of course )
   
   1. The queue max size should be NSOperationQueueDefaultMaxConcurrentOperationCount, instead of arbitrarily choosing 32.
   1. The quality of service should also be set to default (NSQualityOfServiceDefault) instead of choosing to automatically run all commands low priority.
   1. We need developers to be aware that there are issues with their applications attempting too many calls in cases where the queue size is exceeded, or at least warn of potential issues.  I am not sure exactly how I would approach this, something to discuss.
   1. I would like to see tests that demonstrate that we are not blocking and multiple short running commands can complete successfully while a long running command is also running.
   
   It would be nice to know if there have ever been issues here, not sure how to approach this, but I dislike spending cycles fixing issues that have never affected anyone.  Granted this is a small change, so I feel okay about this one regardless of proof that it ever happened. Just curious ...
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org