You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2023/05/16 09:17:51 UTC
[GitHub] [arrow] thisisnic opened a new pull request, #35612: GH-35594: [R] Issue with tzdb 0.4.0 and the shipped arrow tz.cpp
thisisnic opened a new pull request, #35612:
URL: https://github.com/apache/arrow/pull/35612
This PR bumps the vendored version of the date library to commit `cc4685a21e4a4fdae707ad1233c61bbaff241f93`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #35612: GH-35594: [R][C++] Bump vendored date library
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #35612:
URL: https://github.com/apache/arrow/pull/35612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35612: GH-35594: [R][C++] Bump vendored date library
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35612:
URL: https://github.com/apache/arrow/pull/35612#issuecomment-1553452023
Benchmark runs are scheduled for baseline = f6e447944f2a2ab108d5971daf351b7443bc96fb and contender = aa057d02a8234082e78a99e2b9de8449378acf30. aa057d02a8234082e78a99e2b9de8449378acf30 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/13801fb3e3844d4380b86f1a206e0a23...404478f3262c49729749b48f19593d97/)
[Finished :arrow_down:0.41% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/7eb61fd00ae443aa8dfd83fc23bf6a23...a3ad864de04c465b837d703171d20a1b/)
[Finished :arrow_down:1.02% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f53c84274b474803b2a347516e893e87...e97e5b4f66744482bec6570201892f67/)
[Finished :arrow_down:0.54% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/10b99ff42bfb4f3abaa9c23556bb6a34...cec382d5529a4fbf90995b60894fd55e/)
Buildkite builds:
[Finished] [`aa057d02` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2878)
[Finished] [`aa057d02` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2914)
[Finished] [`aa057d02` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2879)
[Finished] [`aa057d02` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2904)
[Finished] [`f6e44794` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2877)
[Finished] [`f6e44794` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2913)
[Finished] [`f6e44794` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2878)
[Finished] [`f6e44794` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2903)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] DavisVaughan commented on pull request #35612: GH-35594: [R] Issue with tzdb 0.4.0 and the shipped arrow tz.cpp
Posted by "DavisVaughan (via GitHub)" <gi...@apache.org>.
DavisVaughan commented on PR #35612:
URL: https://github.com/apache/arrow/pull/35612#issuecomment-1549567386
It seems like almost all of the files in https://github.com/apache/arrow/tree/main/cpp/src/arrow/vendored/datetime are from `<date>` so it might be worth updating all of them rather than just `tz.cpp`, just to keep everything in sync with upstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35612: GH-35594: [R] Issue with tzdb 0.4.0 and the shipped arrow tz.cpp
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35612:
URL: https://github.com/apache/arrow/pull/35612#issuecomment-1549301885
* Closes: #35594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #35612: GH-35594: [R][C++] Bump vendored date library
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #35612:
URL: https://github.com/apache/arrow/pull/35612#issuecomment-1551087801
@github-actions crossbow submit test-r-versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #35612: GH-35594: [R][C++] Bump vendored date library
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #35612:
URL: https://github.com/apache/arrow/pull/35612#issuecomment-1549580741
Indeed, it seems there are a couple other changes to include:
```console
$ git diff --stat 2e19c006e2218447ee31f864191859517603f59f cc4685a21e4a4fdae707ad1233c61bbaff241f93
include/date/date.h | 6 ++--
include/date/iso_week.h | 18 +++++++++---
include/date/ptz.h | 105 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------
include/date/tz.h | 4 +--
src/tz.cpp | 185 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------
test/iso_week/year.pass.cpp | 3 ++
test/testit | 6 ++++
7 files changed, 282 insertions(+), 45 deletions(-)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35612: GH-35594: [R][C++] Bump vendored date library
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35612:
URL: https://github.com/apache/arrow/pull/35612#issuecomment-1553458503
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f53c84274b474803b2a347516e893e87...e97e5b4f66744482bec6570201892f67/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #35612: GH-35594: [R][C++] Issue with tzdb 0.4.0 and the shipped arrow tz.cpp
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #35612:
URL: https://github.com/apache/arrow/pull/35612#issuecomment-1549674713
I think I've got them all now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35612: GH-35594: [R] Issue with tzdb 0.4.0 and the shipped arrow tz.cpp
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35612:
URL: https://github.com/apache/arrow/pull/35612#issuecomment-1549301961
:warning: GitHub issue #35594 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35612: GH-35594: [R][C++] Bump vendored date library
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35612:
URL: https://github.com/apache/arrow/pull/35612#issuecomment-1551091167
Revision: 2d791067a22f42cacb1ef1d3c69d4f5f92192ae1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-bd3d5e4e25](https://github.com/ursacomputing/crossbow/branches/all?query=actions-bd3d5e4e25)
|Task|Status|
|----|------|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/5001800788/jobs/8960954350)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org