You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/05/25 20:24:51 UTC
Review Request 47849: GEODE-1455: Add SecurityTest JUnit category to
outstanding gfsh / JMX security tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47849/
-----------------------------------------------------------
Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
GEODE-1455: Add SecurityTest JUnit category to outstanding gfsh / JMX security tests
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java b4864e9a5453563a94d36e710507314a4d5f034a
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/DataCommandsSecurityTest.java 9c9b4fc8a40ec0ecf192ed9eed75dafe06ab5472
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java 61c913b050373b92a931a41348c2411fb45f40f3
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/SecurityTest.java 3af739e7b36283682708bc18224dd494aa14c1ab
geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CommandOverHttpDUnitTest.java 9687eb71a03420d5f3dae8651336a50c68d6c86e
geode-web/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsOverHttpSecurityTest.java af0cfadcbd3cf57e16f9900baa3f5a8d6f8b169c
Diff: https://reviews.apache.org/r/47849/diff/
Testing
-------
Thanks,
Jens Deppe
Re: Review Request 47849: GEODE-1455: Add SecurityTest JUnit category
to outstanding gfsh / JMX security tests
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47849/#review134865
-----------------------------------------------------------
Ship it!
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/DataCommandsSecurityTest.java (line 34)
<https://reviews.apache.org/r/47849/#comment199807>
Note: this finds a random port at class initialization time. We might want to change this to non-static so it fetches a new random port during instantiation which occurs just before executing each test method.
- Kirk Lund
On May 25, 2016, 8:24 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47849/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 8:24 p.m.)
>
>
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1455: Add SecurityTest JUnit category to outstanding gfsh / JMX security tests
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java b4864e9a5453563a94d36e710507314a4d5f034a
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/DataCommandsSecurityTest.java 9c9b4fc8a40ec0ecf192ed9eed75dafe06ab5472
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java 61c913b050373b92a931a41348c2411fb45f40f3
> geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/SecurityTest.java 3af739e7b36283682708bc18224dd494aa14c1ab
> geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CommandOverHttpDUnitTest.java 9687eb71a03420d5f3dae8651336a50c68d6c86e
> geode-web/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsOverHttpSecurityTest.java af0cfadcbd3cf57e16f9900baa3f5a8d6f8b169c
>
> Diff: https://reviews.apache.org/r/47849/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 47849: GEODE-1455: Add SecurityTest JUnit category
to outstanding gfsh / JMX security tests
Posted by Jens Deppe <jd...@pivotal.io>.
> On May 25, 2016, 8:57 p.m., Jinmei Liao wrote:
> > There is also a MultiUserSecurityTest that we just added that needs to be marked as such.
Thanks!
- Jens
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47849/#review134834
-----------------------------------------------------------
On May 25, 2016, 8:24 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47849/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 8:24 p.m.)
>
>
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1455: Add SecurityTest JUnit category to outstanding gfsh / JMX security tests
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java b4864e9a5453563a94d36e710507314a4d5f034a
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/DataCommandsSecurityTest.java 9c9b4fc8a40ec0ecf192ed9eed75dafe06ab5472
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java 61c913b050373b92a931a41348c2411fb45f40f3
> geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/SecurityTest.java 3af739e7b36283682708bc18224dd494aa14c1ab
> geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CommandOverHttpDUnitTest.java 9687eb71a03420d5f3dae8651336a50c68d6c86e
> geode-web/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsOverHttpSecurityTest.java af0cfadcbd3cf57e16f9900baa3f5a8d6f8b169c
>
> Diff: https://reviews.apache.org/r/47849/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 47849: GEODE-1455: Add SecurityTest JUnit category
to outstanding gfsh / JMX security tests
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47849/#review134834
-----------------------------------------------------------
There is also a MultiUserSecurityTest that we just added that needs to be marked as such.
- Jinmei Liao
On May 25, 2016, 8:24 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47849/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 8:24 p.m.)
>
>
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1455: Add SecurityTest JUnit category to outstanding gfsh / JMX security tests
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java b4864e9a5453563a94d36e710507314a4d5f034a
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/DataCommandsSecurityTest.java 9c9b4fc8a40ec0ecf192ed9eed75dafe06ab5472
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java 61c913b050373b92a931a41348c2411fb45f40f3
> geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/SecurityTest.java 3af739e7b36283682708bc18224dd494aa14c1ab
> geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CommandOverHttpDUnitTest.java 9687eb71a03420d5f3dae8651336a50c68d6c86e
> geode-web/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsOverHttpSecurityTest.java af0cfadcbd3cf57e16f9900baa3f5a8d6f8b169c
>
> Diff: https://reviews.apache.org/r/47849/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 47849: GEODE-1455: Add SecurityTest JUnit category
to outstanding gfsh / JMX security tests
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47849/#review135664
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On May 31, 2016, 3:45 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47849/
> -----------------------------------------------------------
>
> (Updated May 31, 2016, 3:45 p.m.)
>
>
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1455: Add SecurityTest JUnit category to outstanding gfsh / JMX security tests
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java b4864e9a5453563a94d36e710507314a4d5f034a
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/DataCommandsSecurityTest.java 9c9b4fc8a40ec0ecf192ed9eed75dafe06ab5472
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java 61c913b050373b92a931a41348c2411fb45f40f3
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MultiUserDUnitTest.java 5b58b3c70c3d8b890d3f0bef1345f961e3d5aa63
> geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/SecurityTest.java 3af739e7b36283682708bc18224dd494aa14c1ab
> geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CommandOverHttpDUnitTest.java 9687eb71a03420d5f3dae8651336a50c68d6c86e
> geode-web/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsOverHttpSecurityTest.java af0cfadcbd3cf57e16f9900baa3f5a8d6f8b169c
>
> Diff: https://reviews.apache.org/r/47849/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 47849: GEODE-1455: Add SecurityTest JUnit category
to outstanding gfsh / JMX security tests
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47849/
-----------------------------------------------------------
(Updated May 31, 2016, 3:45 p.m.)
Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
GEODE-1455: Add SecurityTest JUnit category to outstanding gfsh / JMX security tests
Diffs (updated)
-----
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java b4864e9a5453563a94d36e710507314a4d5f034a
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/DataCommandsSecurityTest.java 9c9b4fc8a40ec0ecf192ed9eed75dafe06ab5472
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java 61c913b050373b92a931a41348c2411fb45f40f3
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MultiUserDUnitTest.java 5b58b3c70c3d8b890d3f0bef1345f961e3d5aa63
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/SecurityTest.java 3af739e7b36283682708bc18224dd494aa14c1ab
geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CommandOverHttpDUnitTest.java 9687eb71a03420d5f3dae8651336a50c68d6c86e
geode-web/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsOverHttpSecurityTest.java af0cfadcbd3cf57e16f9900baa3f5a8d6f8b169c
Diff: https://reviews.apache.org/r/47849/diff/
Testing
-------
Thanks,
Jens Deppe