You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by jo...@apache.org on 2019/11/26 19:30:00 UTC

[royale-compiler] branch develop updated: MXMLClassReferenceNodeBase: fixed issue where an MXML child element could be incorrectly resolved as a property/style/event, even if it had a different XML namespace prefix from its parent (closes #101)

This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git


The following commit(s) were added to refs/heads/develop by this push:
     new ea3b7d9  MXMLClassReferenceNodeBase: fixed issue where an MXML child element could be incorrectly resolved as a property/style/event, even if it had a different XML namespace prefix from its parent (closes #101)
ea3b7d9 is described below

commit ea3b7d904adbf25177ed9f1d5a7cfc1da249f6a8
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Tue Nov 26 11:29:11 2019 -0800

    MXMLClassReferenceNodeBase: fixed issue where an MXML child element could be incorrectly resolved as a property/style/event, even if it had a different XML namespace prefix from its parent (closes #101)
---
 .../compiler/internal/tree/mxml/MXMLClassReferenceNodeBase.java   | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/compiler/src/main/java/org/apache/royale/compiler/internal/tree/mxml/MXMLClassReferenceNodeBase.java b/compiler/src/main/java/org/apache/royale/compiler/internal/tree/mxml/MXMLClassReferenceNodeBase.java
index 4c66aa4..bc5d7bd 100644
--- a/compiler/src/main/java/org/apache/royale/compiler/internal/tree/mxml/MXMLClassReferenceNodeBase.java
+++ b/compiler/src/main/java/org/apache/royale/compiler/internal/tree/mxml/MXMLClassReferenceNodeBase.java
@@ -436,7 +436,13 @@ abstract class MXMLClassReferenceNodeBase extends MXMLNodeBase implements IMXMLC
         RoyaleProject project = builder.getProject();
 
         // Handle child tags that are property/style/event specifiers.
-        MXMLSpecifierNodeBase childNode = createSpecifierNode(builder, childTag.getShortName());
+        MXMLSpecifierNodeBase childNode = null;
+        // ...but only if the child has the same prefix as the parent -JT
+        // apache/royale-compiler#101
+        if(tag.getPrefix().equals(childTag.getPrefix()))
+        {
+            childNode = createSpecifierNode(builder, childTag.getShortName());
+        }
         if (childNode != null)
         {
             // This tag is not part of the default property value.