You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/10/06 22:52:16 UTC
[GitHub] [bookkeeper] pradeepbn opened a new pull request #2817: Building bookkeeper with gradle on java11
pradeepbn opened a new pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817
- Building bookkeeper with gradle on java11
- Use gradle native solution for using javac rather than specifying it via command line in gradle
Descriptions of the changes in this PR:
### Motivation
(Explain: why you're making that change, what is the problem you're trying to solve)
### Changes
(Describe: what changes you have made)
Master Issue: #<master-issue-number>
> ---
> In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
> checks for pull requests. A pull request can only be merged when it passes precommit checks.
>
> ---
> Be sure to do all of the following to help us incorporate your contribution
> quickly and easily:
>
> If this PR is a BookKeeper Proposal (BP):
>
> - [ ] Make sure the PR title is formatted like:
> `<BP-#>: Description of bookkeeper proposal`
> `e.g. BP-1: 64 bits ledger is support`
> - [ ] Attach the master issue link in the description of this PR.
> - [ ] Attach the google doc link if the BP is written in Google Doc.
>
> Otherwise:
>
> - [ ] Make sure the PR title is formatted like:
> `<Issue #>: Description of pull request`
> `e.g. Issue 123: Description ...`
> - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
> - [ ] Replace `<Issue #>` in the title with the actual Issue number.
>
> ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mauricebarnum commented on pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
mauricebarnum commented on pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#issuecomment-938047880
An alternative approach to generating JNI headers in a manner that the internal compiler will be aware of the dependencies:
https://github.com/mauricebarnum/bookkeeper/commit/049a510b920aab3c7d22898a18596bd68f4e78fd
```diff
diff --git a/circe-checksum/build.gradle b/circe-checksum/build.gradle
index e581ae6c3..5e03ec932 100644
--- a/circe-checksum/build.gradle
+++ b/circe-checksum/build.gradle
@@ -28,18 +28,8 @@ dependencies {
testImplementation depLibs.mockito
}
-task generateJniHeaders(type: JavaCompile) {
- ext {
- javahOutputDir = "$buildDir/javahGenerated"
- }
- classpath = sourceSets.main.compileClasspath
- destinationDir file("${buildDir}/javahGenerated")
- source = sourceSets.main.java
- options.compilerArgs += [
- '-h', file("${buildDir}/javahGenerated"),
- ]
-
- options.annotationProcessorPath = configurations.annotationProcessor
+compileJava {
+ options.headerOutputDirectory = file("${buildDir}/javahGenerated")
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on a change in pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on a change in pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#discussion_r723737706
##########
File path: cpu-affinity/src/main/java/org/apache/bookkeeper/common/util/affinity/impl/CpuAffinityJni.java
##########
@@ -21,7 +21,6 @@
package org.apache.bookkeeper.common.util.affinity.impl;
import java.io.IOException;
-
Review comment:
Kindly remove this file from changelist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra merged pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
hsaputra merged pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mauricebarnum commented on pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
mauricebarnum commented on pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#issuecomment-938127021
rerun failed checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pradeepbn commented on pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
pradeepbn commented on pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#issuecomment-938197770
rerun failed checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#issuecomment-938198984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#issuecomment-938198984
rerun failed checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pradeepbn commented on pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
pradeepbn commented on pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#issuecomment-938119210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra commented on pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
hsaputra commented on pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#issuecomment-938235077
Will merge this by tomorrow EOD if no more comments or concern. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mauricebarnum commented on pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
mauricebarnum commented on pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#issuecomment-938047880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pradeepbn commented on a change in pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
pradeepbn commented on a change in pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#discussion_r723741907
##########
File path: cpu-affinity/src/main/java/org/apache/bookkeeper/common/util/affinity/impl/CpuAffinityJni.java
##########
@@ -21,7 +21,6 @@
package org.apache.bookkeeper.common.util.affinity.impl;
import java.io.IOException;
-
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#issuecomment-938200017
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra commented on pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
hsaputra commented on pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#issuecomment-938858906
The PR is merged. Thanks @pradeepbn for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pradeepbn commented on pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
pradeepbn commented on pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#issuecomment-938119210
> `./gradlew jar -x test` worked for me with `JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home`
Verified on my local as well. It works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mauricebarnum commented on pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
mauricebarnum commented on pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#issuecomment-938116756
`./gradlew jar -x test` worked for me with `JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pradeepbn commented on a change in pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
pradeepbn commented on a change in pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#discussion_r723741907
##########
File path: cpu-affinity/src/main/java/org/apache/bookkeeper/common/util/affinity/impl/CpuAffinityJni.java
##########
@@ -21,7 +21,6 @@
package org.apache.bookkeeper.common.util.affinity.impl;
import java.io.IOException;
-
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on a change in pull request #2817: Building bookkeeper with gradle on java11
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on a change in pull request #2817:
URL: https://github.com/apache/bookkeeper/pull/2817#discussion_r723737706
##########
File path: cpu-affinity/src/main/java/org/apache/bookkeeper/common/util/affinity/impl/CpuAffinityJni.java
##########
@@ -21,7 +21,6 @@
package org.apache.bookkeeper.common.util.affinity.impl;
import java.io.IOException;
-
Review comment:
Kindly remove this file from changelist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org