[jira] [Commented] (RANGER-864) RangerPolicy.set(List) methods append to existing value, instead of overwriting

["rangerqa (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RANGER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174410#comment-15174410 ] 

rangerqa commented on RANGER-864:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12790765/0001-RANGER-864-RangerPolicy.set-List-methods-append-to-e.patch
  against master revision bdf44e4.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    +1 checkstyle.  The patch generated 0 code style errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-RANGER-Build/76//testReport/
Console output: https://builds.apache.org/job/PreCommit-RANGER-Build/76//console

This message is automatically generated.

> RangerPolicy.set(List<?>) methods append to existing value, instead of overwriting
> ----------------------------------------------------------------------------------
>
>                 Key: RANGER-864
>                 URL: https://issues.apache.org/jira/browse/RANGER-864
>             Project: Ranger
>          Issue Type: Bug
>          Components: plugins
>    Affects Versions: 0.5.0, 0.5.1, 0.5.2, 0.6.0
>            Reporter: Madhan Neethiraj
>            Assignee: Madhan Neethiraj
>         Attachments: 0001-RANGER-864-RangerPolicy.set-List-methods-append-to-e.patch
>
>
> Following methods in RangerPolicy append to existing value, instead of overwriting:
>  - setUsers()
>  - setGroups()
>  - setAccesses()
>  - setConditions()
> This behavior does not cause issues with current usage of these methods, as these are called only when the existing list is empty. However, these methods should be fixed to be consistent with rest of set(List<?>) methods in org.apache.ranger.plugin.model package.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)