[GitHub] [logging-log4cxx] stephen-webb commented on issue #21: Add support for building log4cxx as a statically linked library on Windows

[GitBox <gi...@apache.org>]

stephen-webb commented on issue #21: Add support for building log4cxx as a statically linked library on Windows
URL: https://github.com/apache/logging-log4cxx/pull/21#issuecomment-605849220
 
 
   No, they work the same, except the Build shared is on by default. The =on
   does no more than the existence of a definition.
   
   
   On Mon, Mar 30, 2020, 6:44 PM Thorsten Schöning <no...@github.com>
   wrote:
   
   > *@ams-tschoening* requested changes on this pull request.
   > ------------------------------
   >
   > In src/site/apt/building/cmake.apt
   > <https://github.com/apache/logging-log4cxx/pull/21#discussion_r390155388>:
   >
   > > @@ -50,6 +50,12 @@ $ sudo make install
   >  *------------------------+---------------------------------------------------------------------------------------------+
   >  | -DBUILD_SHARED_LIBS=off| Build log4cxx as a static library. A dynamically linked log4cxx library is built by default.|
   >  |                        | Any compilation unit that includes a log4cxx header must define LOG4CXX_STATIC.             |
   > +*------------------------+---------------------------------------------------------------------------------------------+
   > +| -DAPU_STATIC           | Link to the APR-Util static library. By default, the log4cxx shared library is linked to the|
   >
   > Any reason why -DAPU_STATIC and -DAPR_STATIC are not documented with
   > something like =off|on , like -DBUILD_SHARED_LIBS is? Does this work
   > differently or ...?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/logging-log4cxx/pull/21#pullrequestreview-371753644>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ANLOSDWPWKXFOJOFOJQBYKTRKBEUPANCNFSM4LEUWTVQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services