You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/04 15:10:41 UTC
[GitHub] [cloudstack] JoaoJandre opened a new pull request, #7052: Allow domain admins to inform tags when creating offerings
JoaoJandre opened a new pull request, #7052:
URL: https://github.com/apache/cloudstack/pull/7052
### Description
ACS only allows root admins to enter tags during the creation of service, disk, and network offerings; however, in private cloud environments, domain admin accounts may have autonomy and knowledge of the infrastructure, being able to direct resources according to their needs.
To enable this behavior, a new account-level setting (`allow.domain.admins.to.create.offerings.with.tags`) has been created. When disabled (default), the previous behavior is maintained; when enabled, the domain admin account can enter tags when creating disk and service offerings. As we did not see a use case for network offering tags, these were not touched, that is, this new configuration will not affect network offering creation.
In addition, the UI has been changed to allow domain admins to inform these fields when the configuration is enabled. To enable this UI behavior, a new API was created, `isAccountAllowedToCreateOfferingsWithTags`, which only receives the ID of the account to be validated, and returns true if the account can create offerings with tags and false otherwise.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
With the `allow.domain.admins.to.create.offerings.with.tags` set to false (default), and using CloudMonkey logged in as a domain admin, I tried to call the create/update service/disk offering APIs while passing some tags as parameters, all the calls returned exceptions.
I Then set the configuration to `true`, and recalled the APIs with the same parameters, and all of them successfully ran.
In the UI, logged in as a domain admin, and the `allow.domain.admins.to.create.offerings.with.tags` set to false, I opened the create disk/compute offering forms, and the tags fields did not appear.
I then set the configuration to `true`, and retried opening the create disk/compute offering forms, the tags did appear, and I successfully created the offerings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
JoaoJandre commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372131360
> @JoaoJandre please have a look at the errors with Simulator CI (ignore the errors with test_tags )
The only error without test_tags was an insufficient capacity exception in a VM deploy and it doesn't look correlated with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1375995024
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1371169780
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
JoaoJandre commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372138209
> @JoaoJandre what's the goal of this enhancement ?
ACS only allows root admins to enter tags during the creation of service, disk, and network offerings; however, in private cloud environments, domain admin accounts may have autonomy and knowledge of the infrastructure, being able to direct resources according to their needs.
To enable this behavior, a new account-level setting (`allow.domain.admins.to.create.offerings.with.tags`) has been created. When disabled (default), the previous behavior is maintained; when enabled, the domain admin account can enter tags when creating disk and service offerings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1375820386
it could do with an integration test though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1371139740
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7052](https://codecov.io/gh/apache/cloudstack/pull/7052?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6eba36) into [main](https://codecov.io/gh/apache/cloudstack/commit/d0b34b75765d3f36b595f7f5659cdb282e67e3ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0b34b7) will **increase** coverage by `0.00%`.
> The diff coverage is `7.14%`.
```diff
@@ Coverage Diff @@
## main #7052 +/- ##
=========================================
Coverage 11.58% 11.58%
- Complexity 7548 7550 +2
=========================================
Files 2494 2494
Lines 247065 247075 +10
Branches 38613 38615 +2
=========================================
+ Hits 28629 28634 +5
- Misses 214692 214696 +4
- Partials 3744 3745 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...in/java/com/cloud/server/ManagementServerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3NlcnZlci9NYW5hZ2VtZW50U2VydmVySW1wbC5qYXZh) | `5.18% <0.00%> (-0.01%)` | :arrow_down: |
| [.../cloud/configuration/ConfigurationManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbmZpZ3VyYXRpb24vQ29uZmlndXJhdGlvbk1hbmFnZXJJbXBsLmphdmE=) | `12.48% <7.69%> (-0.01%)` | :arrow_down: |
| [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/7052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `28.84% <0.00%> (+7.69%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1375996169
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1371170383
@JoaoJandre
please have a look at the errors with Simulator CI (ignore the errors with test_tags )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1371171049
@JoaoJandre
what's the goal of this enhancement ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372480452
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7052)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7052&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7052&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7052&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7052&metric=new_coverage&view=list) [1.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7052&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7052&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7052&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372162064
> > @JoaoJandre what's the goal of this enhancement ?
>
> ACS only allows root admins to enter tags during the creation of service, disk, and network offerings; however, in private cloud environments, domain admin accounts may have autonomy and knowledge of the infrastructure, being able to direct resources according to their needs.
>
> To enable this behavior, a new account-level setting (`allow.domain.admins.to.create.offerings.with.tags`) has been created. When disabled (default), the previous behavior is maintained; when enabled, the domain admin account can enter tags when creating disk and service offerings.
@JoaoJandre
for domain admins, how do they get the list of available tags ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1375822748
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1375821075
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
JoaoJandre commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372363589
> > > @JoaoJandre please have a look at the errors with Simulator CI (ignore the errors with test_tags )
> >
> >
> > The only error without test_tags was an insufficient capacity exception in a VM deploy and it doesn't look correlated with this PR.
>
> @JoaoJandre there is another error test_affinity_groups_projects, which may or not be related to your change.
That is the one I was talking about, the test_affinity_groups_projects test's error doesn't look correlated with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1375918395
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1371132840
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7052)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7052&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7052&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7052&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7052&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7052&metric=new_coverage&view=list) [1.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7052&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7052&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7052&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372159292
> > @JoaoJandre please have a look at the errors with Simulator CI (ignore the errors with test_tags )
>
> The only error without test_tags was an insufficient capacity exception in a VM deploy and it doesn't look correlated with this PR.
@JoaoJandre
there is another error test_affinity_groups_projects, which may or not be related to your change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
JoaoJandre commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372374425
> > > @JoaoJandre what's the goal of this enhancement ?
> >
> >
> > ACS only allows root admins to enter tags during the creation of service, disk, and network offerings; however, in private cloud environments, domain admin accounts may have autonomy and knowledge of the infrastructure, being able to direct resources according to their needs.
> > To enable this behavior, a new account-level setting (`allow.domain.admins.to.create.offerings.with.tags`) has been created. When disabled (default), the previous behavior is maintained; when enabled, the domain admin account can enter tags when creating disk and service offerings.
>
> @JoaoJandre for domain admins, how do they get the list of available tags ?
@weizhouapache the default domain admin role has permission to list storage and host tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7052:
URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372410568
> > > > @JoaoJandre please have a look at the errors with Simulator CI (ignore the errors with test_tags )
> > >
> > >
> > > The only error without test_tags was an insufficient capacity exception in a VM deploy and it doesn't look correlated with this PR.
> >
> >
> > @JoaoJandre there is another error test_affinity_groups_projects, which may or not be related to your change.
>
> That is the one I was talking about, the test_affinity_groups_projects test's error doesn't look correlated with this PR.
OK. closed/reopened this PR to rekick the simulator CI. let's see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #7052: Allow domain admins to inform tags when creating offerings
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #7052: Allow domain admins to inform tags when creating offerings
URL: https://github.com/apache/cloudstack/pull/7052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org