You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/30 15:09:11 UTC

[GitHub] [rocketmq] freshchen opened a new issue, #4539: The following classes cannot easily register Hooks, and some even require reflection to obtain filed.

freshchen opened a new issue, #4539:
URL: https://github.com/apache/rocketmq/issues/4539

   The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow the [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal). To avoid unnecessary duplication, please check whether there is a previous issue before filing a new one.
   
   It is recommended to start a discussion thread in the [mailing lists](http://rocketmq.apache.org/about/contact/) in cases of discussing your deployment plan, API clarification, and other non-bug-reporting issues.
   We welcome any friendly suggestions, bug fixes, collaboration, and other improvements.
   
   Please ensure that your bug report is clear and self-contained. Otherwise, it would take additional rounds of communication, thus more time, to understand the problem itself.
   
   Generally, fixing an issue goes through the following steps:
   1. Understand the issue reported;
   1. Reproduce the unexpected behavior locally;
   1. Perform root cause analysis to identify the underlying problem;
   1. Create test cases to cover the identified problem;
   1. Work out a solution to rectify the behavior and make the newly created test cases pass;
   1. Make a pull request and go through peer review;
   
   As a result, it would be very helpful yet challenging if you could provide an isolated project reproducing your reported issue. Anyway, please ensure your issue report is informative enough for the community to pick up. At a minimum, include the following hints:
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   - What did you do (The steps to reproduce)?
   
   - What is expected to see?
   
   - What did you see instead?
   
   2. Please tell us about your environment:
   
   3. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):
   
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
   
   4. If there are some sub-tasks involved, use -[] for each sub-task and create a corresponding issue to map to the sub-task:
   
   - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here, 
   - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 description here,
   - ...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] zhangyanglei commented on issue #4539: The following classes cannot easily register Hooks, and some even require reflection to obtain filed. 1 DefaultLitePullConsumer 2 DefaultMQProducer 3 DefaultMQPushConsumer

Posted by GitBox <gi...@apache.org>.
zhangyanglei commented on issue #4539:
URL: https://github.com/apache/rocketmq/issues/4539#issuecomment-1302907810

   所以有拦截器接口定义吗 类似于kafka的ProducerInterceptor


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] freshchen commented on issue #4539: The following classes cannot easily register Hooks, and some even require reflection to obtain filed. 1 DefaultLitePullConsumer 2 DefaultMQProducer 3 DefaultMQPushConsumer

Posted by GitBox <gi...@apache.org>.
freshchen commented on issue #4539:
URL: https://github.com/apache/rocketmq/issues/4539#issuecomment-1171801507

   Im using rocketmq-spring-boot-starter and want add some custom hooks from zipkin trace. seems i need modify 3 class during system initialization. 1 DefaultLitePullConsumer 2 DefaultMQProducer 3 DefaultMQPushConsumer
   
   For DefaultLitePullConsumer I cannot get defaultLitePullConsumerImpl field without reflection to execute registerConsumeMessageHook method.
   For DefaultMQProducer and DefaultMQPushConsumer get inner impl field is Deprecated. 
   
   suggest add the corresponding register hook method for the above facade class
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] lizhiboo commented on issue #4539: The following classes cannot easily register Hooks, and some even require reflection to obtain filed. 1 DefaultLitePullConsumer 2 DefaultMQProducer 3 DefaultMQPushConsumer

Posted by GitBox <gi...@apache.org>.
lizhiboo commented on issue #4539:
URL: https://github.com/apache/rocketmq/issues/4539#issuecomment-1171779602

   @freshchen can u describe the question specifically, u can give some examples, and do u have any suggestion to these question?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] lizhanhui commented on issue #4539: The following classes cannot easily register Hooks, and some even require reflection to obtain filed. 1 DefaultLitePullConsumer 2 DefaultMQProducer 3 DefaultMQPushConsumer

Posted by GitBox <gi...@apache.org>.
lizhanhui commented on issue #4539:
URL: https://github.com/apache/rocketmq/issues/4539#issuecomment-1171886255

   We'd better add a filter or interceptor chain before pub/sub each message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] vacuityv commented on issue #4539: The following classes cannot easily register Hooks, and some even require reflection to obtain filed. 1 DefaultLitePullConsumer 2 DefaultMQProducer 3 DefaultMQPushConsumer

Posted by "vacuityv (via GitHub)" <gi...@apache.org>.
vacuityv commented on issue #4539:
URL: https://github.com/apache/rocketmq/issues/4539#issuecomment-1586997251

   现在有解决方案吗 @lizhanhui 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org