You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2020/12/02 03:23:55 UTC
[GitHub] [incubator-hop] mookkiah opened a new pull request #427: WIP: Hop 2217
mookkiah opened a new pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427
Porting java files done
Need to work on assemblies and exclude jars to keep the final artifact light.
May need to move code between database and transforms based on the feedback.
Need to rename variable to cleanup old terminology.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #427: WIP: Hop 2217
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-737054285
one note, we should change it in the main pom too...
The header has to be:
```
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
```
bit of an adjusted header for ASF projects
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mattcasters commented on pull request #427: WIP: HOP-2217
Posted by GitBox <gi...@apache.org>.
mattcasters commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-758603623
Hi @mookkiah I've set up my Cassandra test environment. First thing I tried is the Cassandra Output transform.
I usually test the connection with the "Get table names" button on the "Write options" tab but I'm getting a NCDFE:
java.lang.NoClassDefFoundError: Could not initialize class com.datastax.driver.core.Cluster
at org.apache.hop.databases.cassandra.driver.datastax.DriverConnection.getCluster(DriverConnection.java:123)
at org.apache.hop.databases.cassandra.driver.datastax.DriverConnection.getKeyspace(DriverConnection.java:147)
at org.apache.hop.pipeline.transforms.cassandraoutput.CassandraOutputDialog.setupTablesCombo(CassandraOutputDialog.java:1115)
at org.apache.hop.pipeline.transforms.cassandraoutput.CassandraOutputDialog$6.widgetSelected(CassandraOutputDialog.java:438)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:252)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5687)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1423)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4955)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4448)
at org.apache.hop.pipeline.transforms.cassandraoutput.CassandraOutputDialog.open(CassandraOutputDialog.java:1078)
at org.apache.hop.ui.hopgui.file.pipeline.delegates.HopGuiPipelineTransformDelegate.editTransform(HopGuiPipelineTransformDelegate.java:161)
at org.apache.hop.ui.hopgui.file.pipeline.HopGuiPipelineGraph.editTransform(HopGuiPipelineGraph.java:3215)
at org.apache.hop.ui.hopgui.file.pipeline.HopGuiPipelineGraph.mouseUp(HopGuiPipelineGraph.java:877)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:224)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5687)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1423)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4955)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4448)
at org.apache.hop.ui.hopgui.HopGui.open(HopGui.java:376)
at org.apache.hop.ui.hopgui.HopGui.main(HopGui.java:312)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mookkiah commented on pull request #427: Hop 2217
Posted by GitBox <gi...@apache.org>.
mookkiah commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-739690145
https://vocon-it.com/2016/12/08/cassandra-hello-world-example/
For testing if you don't have have Cassandra
```
$ docker run -it --rm --name cassandra-node1 -p7000:7000 -p7001:7001 -p9042:9042 -p9160:9160 cassandra
$ docker run -it --rm -e CQLSH_HOST=$(docker inspect --format='{{ .NetworkSettings.IPAddress }}' cassandra-node1) --name cassandra-client --entrypoint=cqlsh cassandra
cqlsh> create keyspace mykeyspace with replication = {'class':'SimpleStrategy','replication_factor' : 2};
cqlsh> use mykeyspace;
cqlsh:mykeyspace> create table usertable (userid int primary key, usergivenname varchar, userfamilyname varchar, userprofession varchar);
cqlsh:mykeyspace>
cqlsh:mykeyspace> insert into usertable (userid, usergivenname, userfamilyname, userprofession) values (1, 'Oliver', 'Veits', 'Freelancer');
cqlsh:mykeyspace>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #427: Hop 2217
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-752737860
I stopped halfway this needs quite a lot of changes before we can consider merging:
2 more points that worry me:
- are all new included libraries a compatible license?
- we should either create a database type for cassandra to store the metadata, or create a new metadata type to store the cassandra info, I do not like that all the fields are in the transform every time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mookkiah commented on pull request #427: Hop 2217
Posted by GitBox <gi...@apache.org>.
mookkiah commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-752829036
Thanks @hansva for the review. I will work on the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva closed pull request #427: WIP: Hop 2217
Posted by GitBox <gi...@apache.org>.
hansva closed pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mookkiah commented on a change in pull request #427: WIP: Hop 2217
Posted by GitBox <gi...@apache.org>.
mookkiah commented on a change in pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#discussion_r550940400
##########
File path: assemblies/plugins/transforms/cassandra/pom.xml
##########
@@ -0,0 +1,573 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.hop</groupId>
+ <artifactId>hop-assemblies-plugins-transforms</artifactId>
+ <version>0.50-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>hop-assemblies-plugins-transforms-cassandra</artifactId>
+ <packaging>pom</packaging>
+
+ <name>Hop Assemblies Plugins Transforms Cassandra</name>
+ <description></description>
+
+ <properties>
+ <!-- Test running configuration -->
+ <cassandra.version>3.11.1</cassandra.version>
+ <swt.version>4.6</swt.version>
+ <cassandra-driver.version>3.4.0</cassandra-driver.version>
+ <mockito.version>1.9.5</mockito.version>
+ <apache.commons.lang3.version>3.0</apache.commons.lang3.version>
+ <commons-lang.version>2.6</commons-lang.version>
+ <jface.version>3.3.0-I20070606-0010</jface.version>
+ <commons-xul.version>9.2.0.0-SNAPSHOT</commons-xul.version>
+ <guava.version>17.0</guava.version>
+ <snakeyaml.version>1.11</snakeyaml.version>
+ <netty.version>4.0.44.Final</netty.version>
+ <clearspring-stream.version>2.8.0</clearspring-stream.version>
+ <sigar.version>1.6.4</sigar.version>
+ <dropwizard-metrics.version>3.1.0</dropwizard-metrics.version>
+ <lz4.version>1.3.0</lz4.version>
+ <jna.version>4.0.0</jna.version>
+ <jamm.version>0.3.0</jamm.version>
+ <high-scale-lib.version>1.0.6</high-scale-lib.version>
+ <supercsv.version>2.1.0</supercsv.version>
+ <libthrift.version>0.12.0</libthrift.version>
+ <junit.version>4.11</junit.version>
+ </properties>
+
+<dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.eclipse.swt</groupId>
+ <artifactId>org.eclipse.swt.gtk.linux.x86_64</artifactId>
+ <version>${swt.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
Review comment:
removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mookkiah commented on pull request #427: WIP: HOP-2217
Posted by GitBox <gi...@apache.org>.
mookkiah commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-761402030
breaking change.
https://github.com/apache/incubator-hop/compare/ddb600300...mookkiah:hop-2217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mookkiah commented on a change in pull request #427: WIP: Hop 2217
Posted by GitBox <gi...@apache.org>.
mookkiah commented on a change in pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#discussion_r550940520
##########
File path: plugins/databases/pom.xml
##########
@@ -81,7 +81,7 @@
<module>sapdb</module>
<module>sqlite</module>
<module>googlebigquery</module>
- <module>snowflake</module>
+ <module>snowflake</module>
Review comment:
formatting issue due to unwanted white spaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mattcasters commented on pull request #427: WIP: HOP-2217
Posted by GitBox <gi...@apache.org>.
mattcasters commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-804729186
Note: I'll be doing more tests against this PR and will merge somewhere this week. Thanks for all the hard work on this @mookkiah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on a change in pull request #427: Hop 2217
Posted by GitBox <gi...@apache.org>.
hansva commented on a change in pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#discussion_r550304929
##########
File path: plugins/databases/pom.xml
##########
@@ -81,7 +81,7 @@
<module>sapdb</module>
<module>sqlite</module>
<module>googlebigquery</module>
- <module>snowflake</module>
+ <module>snowflake</module>
Review comment:
unrelated to this PR remove
##########
File path: assemblies/plugins/transforms/cassandra/pom.xml
##########
@@ -0,0 +1,573 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.hop</groupId>
+ <artifactId>hop-assemblies-plugins-transforms</artifactId>
+ <version>0.50-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>hop-assemblies-plugins-transforms-cassandra</artifactId>
+ <packaging>pom</packaging>
+
+ <name>Hop Assemblies Plugins Transforms Cassandra</name>
+ <description></description>
+
+ <properties>
+ <!-- Test running configuration -->
+ <cassandra.version>3.11.1</cassandra.version>
+ <swt.version>4.6</swt.version>
+ <cassandra-driver.version>3.4.0</cassandra-driver.version>
+ <mockito.version>1.9.5</mockito.version>
+ <apache.commons.lang3.version>3.0</apache.commons.lang3.version>
+ <commons-lang.version>2.6</commons-lang.version>
+ <jface.version>3.3.0-I20070606-0010</jface.version>
+ <commons-xul.version>9.2.0.0-SNAPSHOT</commons-xul.version>
+ <guava.version>17.0</guava.version>
Review comment:
defined in main pom, remove
##########
File path: assemblies/plugins/transforms/cassandra/pom.xml
##########
@@ -0,0 +1,573 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.hop</groupId>
+ <artifactId>hop-assemblies-plugins-transforms</artifactId>
+ <version>0.50-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>hop-assemblies-plugins-transforms-cassandra</artifactId>
+ <packaging>pom</packaging>
+
+ <name>Hop Assemblies Plugins Transforms Cassandra</name>
+ <description></description>
+
+ <properties>
+ <!-- Test running configuration -->
+ <cassandra.version>3.11.1</cassandra.version>
+ <swt.version>4.6</swt.version>
+ <cassandra-driver.version>3.4.0</cassandra-driver.version>
+ <mockito.version>1.9.5</mockito.version>
+ <apache.commons.lang3.version>3.0</apache.commons.lang3.version>
+ <commons-lang.version>2.6</commons-lang.version>
+ <jface.version>3.3.0-I20070606-0010</jface.version>
+ <commons-xul.version>9.2.0.0-SNAPSHOT</commons-xul.version>
+ <guava.version>17.0</guava.version>
+ <snakeyaml.version>1.11</snakeyaml.version>
+ <netty.version>4.0.44.Final</netty.version>
+ <clearspring-stream.version>2.8.0</clearspring-stream.version>
+ <sigar.version>1.6.4</sigar.version>
+ <dropwizard-metrics.version>3.1.0</dropwizard-metrics.version>
+ <lz4.version>1.3.0</lz4.version>
+ <jna.version>4.0.0</jna.version>
+ <jamm.version>0.3.0</jamm.version>
+ <high-scale-lib.version>1.0.6</high-scale-lib.version>
+ <supercsv.version>2.1.0</supercsv.version>
+ <libthrift.version>0.12.0</libthrift.version>
+ <junit.version>4.11</junit.version>
+ </properties>
+
+<dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.eclipse.swt</groupId>
+ <artifactId>org.eclipse.swt.gtk.linux.x86_64</artifactId>
+ <version>${swt.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse</groupId>
+ <artifactId>jface</artifactId>
+ <version>${jface.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.cassandra</groupId>
+ <artifactId>cassandra-all</artifactId>
+ <version>${cassandra.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>${guava.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
Review comment:
remove
##########
File path: assemblies/plugins/transforms/cassandra/pom.xml
##########
@@ -0,0 +1,573 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.hop</groupId>
+ <artifactId>hop-assemblies-plugins-transforms</artifactId>
+ <version>0.50-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>hop-assemblies-plugins-transforms-cassandra</artifactId>
+ <packaging>pom</packaging>
+
+ <name>Hop Assemblies Plugins Transforms Cassandra</name>
+ <description></description>
+
+ <properties>
+ <!-- Test running configuration -->
+ <cassandra.version>3.11.1</cassandra.version>
+ <swt.version>4.6</swt.version>
+ <cassandra-driver.version>3.4.0</cassandra-driver.version>
+ <mockito.version>1.9.5</mockito.version>
+ <apache.commons.lang3.version>3.0</apache.commons.lang3.version>
+ <commons-lang.version>2.6</commons-lang.version>
+ <jface.version>3.3.0-I20070606-0010</jface.version>
+ <commons-xul.version>9.2.0.0-SNAPSHOT</commons-xul.version>
+ <guava.version>17.0</guava.version>
+ <snakeyaml.version>1.11</snakeyaml.version>
+ <netty.version>4.0.44.Final</netty.version>
+ <clearspring-stream.version>2.8.0</clearspring-stream.version>
+ <sigar.version>1.6.4</sigar.version>
+ <dropwizard-metrics.version>3.1.0</dropwizard-metrics.version>
+ <lz4.version>1.3.0</lz4.version>
+ <jna.version>4.0.0</jna.version>
+ <jamm.version>0.3.0</jamm.version>
+ <high-scale-lib.version>1.0.6</high-scale-lib.version>
+ <supercsv.version>2.1.0</supercsv.version>
+ <libthrift.version>0.12.0</libthrift.version>
+ <junit.version>4.11</junit.version>
+ </properties>
+
+<dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.eclipse.swt</groupId>
+ <artifactId>org.eclipse.swt.gtk.linux.x86_64</artifactId>
+ <version>${swt.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse</groupId>
+ <artifactId>jface</artifactId>
+ <version>${jface.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.cassandra</groupId>
+ <artifactId>cassandra-all</artifactId>
+ <version>${cassandra.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>${guava.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.datastax.cassandra</groupId>
+ <artifactId>cassandra-driver-core</artifactId>
+ <version>${cassandra-driver.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.datastax.cassandra</groupId>
+ <artifactId>cassandra-driver-extras</artifactId>
+ <version>${cassandra-driver.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>commons-lang</groupId>
+ <artifactId>commons-lang</artifactId>
+ <version>${commons-lang.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>org.yaml</groupId>
+ <artifactId>snakeyaml</artifactId>
+ <version>${snakeyaml.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.boundary</groupId>
+ <artifactId>high-scale-lib</artifactId>
+ <version>${high-scale-lib.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.github.jbellis</groupId>
+ <artifactId>jamm</artifactId>
+ <version>${jamm.version}</version>
+ <scope>runtime</scope>
+ </dependency>
+ <dependency>
+ <groupId>net.java.dev.jna</groupId>
+ <artifactId>jna</artifactId>
+ <version>${jna.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>net.jpountz.lz4</groupId>
+ <artifactId>lz4</artifactId>
+ <version>${lz4.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>io.dropwizard.metrics</groupId>
+ <artifactId>metrics-core</artifactId>
+ <version>${dropwizard-metrics.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>io.dropwizard.metrics</groupId>
+ <artifactId>metrics-jvm</artifactId>
+ <version>${dropwizard-metrics.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.fusesource</groupId>
+ <artifactId>sigar</artifactId>
+ <version>${sigar.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.clearspring.analytics</groupId>
+ <artifactId>stream</artifactId>
+ <version>${clearspring-stream.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>net.sf.supercsv</groupId>
+ <artifactId>super-csv</artifactId>
+ <version>${supercsv.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.thrift</groupId>
+ <artifactId>libthrift</artifactId>
+ <version>${libthrift.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>${apache.commons.lang3.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-common</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-transport</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-buffer</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-codec</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-handler</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>pentaho-kettle</groupId>
+ <artifactId>kettle-engine</artifactId>
+ <version>${pdi.version}</version>
+ <classifier>tests</classifier>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>${junit.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-all</artifactId>
+ <version>${mockito.version}</version>
+ <scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
+ <version>${xml-apis.version}</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hop</groupId>
+ <artifactId>hop-transform-cassandra</artifactId>
+ <version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <artifactId>*</artifactId>
+ <groupId>*</groupId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.cassandra</groupId>
+ <artifactId>cassandra-all</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.datastax.cassandra</groupId>
+ <artifactId>cassandra-driver-core</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.datastax.cassandra</groupId>
+ <artifactId>cassandra-driver-extras</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.boundary</groupId>
+ <artifactId>high-scale-lib</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.github.jbellis</groupId>
+ <artifactId>jamm</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>net.java.dev.jna</groupId>
+ <artifactId>jna</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.thrift</groupId>
+ <artifactId>libthrift</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>net.jpountz.lz4</groupId>
+ <artifactId>lz4</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>io.dropwizard.metrics</groupId>
+ <artifactId>metrics-core</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>io.dropwizard.metrics</groupId>
+ <artifactId>metrics-jvm</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-common</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-transport</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-buffer</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-codec</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-handler</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.fusesource</groupId>
+ <artifactId>sigar</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.yaml</groupId>
+ <artifactId>snakeyaml</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.clearspring.analytics</groupId>
+ <artifactId>stream</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>net.sf.supercsv</groupId>
+ <artifactId>super-csv</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.codehaus.jackson</groupId>
+ <artifactId>jackson-core-asl</artifactId>
+ <scope>compile</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.codehaus.jackson</groupId>
+ <artifactId>jackson-mapper-asl</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
Review comment:
should not be needed
##########
File path: assemblies/plugins/transforms/cassandra/pom.xml
##########
@@ -0,0 +1,573 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.hop</groupId>
+ <artifactId>hop-assemblies-plugins-transforms</artifactId>
+ <version>0.50-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>hop-assemblies-plugins-transforms-cassandra</artifactId>
+ <packaging>pom</packaging>
+
+ <name>Hop Assemblies Plugins Transforms Cassandra</name>
+ <description></description>
+
+ <properties>
+ <!-- Test running configuration -->
+ <cassandra.version>3.11.1</cassandra.version>
+ <swt.version>4.6</swt.version>
+ <cassandra-driver.version>3.4.0</cassandra-driver.version>
+ <mockito.version>1.9.5</mockito.version>
+ <apache.commons.lang3.version>3.0</apache.commons.lang3.version>
+ <commons-lang.version>2.6</commons-lang.version>
+ <jface.version>3.3.0-I20070606-0010</jface.version>
+ <commons-xul.version>9.2.0.0-SNAPSHOT</commons-xul.version>
+ <guava.version>17.0</guava.version>
+ <snakeyaml.version>1.11</snakeyaml.version>
+ <netty.version>4.0.44.Final</netty.version>
+ <clearspring-stream.version>2.8.0</clearspring-stream.version>
+ <sigar.version>1.6.4</sigar.version>
+ <dropwizard-metrics.version>3.1.0</dropwizard-metrics.version>
+ <lz4.version>1.3.0</lz4.version>
+ <jna.version>4.0.0</jna.version>
+ <jamm.version>0.3.0</jamm.version>
+ <high-scale-lib.version>1.0.6</high-scale-lib.version>
+ <supercsv.version>2.1.0</supercsv.version>
+ <libthrift.version>0.12.0</libthrift.version>
+ <junit.version>4.11</junit.version>
+ </properties>
+
+<dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.eclipse.swt</groupId>
+ <artifactId>org.eclipse.swt.gtk.linux.x86_64</artifactId>
+ <version>${swt.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
Review comment:
remove this one
##########
File path: plugins/transforms/cassandra/pom.xml
##########
@@ -0,0 +1,426 @@
+<?xml version="1.0"?>
Review comment:
same remarks as the assemblies pom
##########
File path: assemblies/plugins/transforms/cassandra/src/assembly/assembly.xml
##########
@@ -0,0 +1,60 @@
+<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3 http://maven.apache.org/xsd/assembly-1.1.3.xsd">
+ <id>hop-transform-cassandra</id>
+ <formats>
+ <format>zip</format>
+ </formats>
+ <baseDirectory>transforms/cassandra</baseDirectory>
+ <files>
+ <file>
+ <source>${project.basedir}/src/main/resources/version.xml</source>
+ <outputDirectory>.</outputDirectory>
+ <filtered>true</filtered>
+ </file>
+ </files>
+ <fileSets>
+ <fileSet>
+ <outputDirectory>lib</outputDirectory>
+ <excludes>
+ <exclude>**/*</exclude>
+ </excludes>
+ </fileSet>
+ </fileSets>
+ <dependencySets>
+ <dependencySet>
+ <useProjectArtifact>false</useProjectArtifact>
+ <includes>
+ <include>org.apache.hop:hop-transform-cassandra:jar</include>
+ </includes>
+ </dependencySet>
+ <dependencySet>
+ <outputDirectory>lib</outputDirectory>
+ <unpack>false</unpack>
+ <includes>
+ <include>org.apache.cassandra:cassandra-all</include>
+ <include>com.datastax.cassandra:cassandra-driver-core</include>
+ <include>com.datastax.cassandra:cassandra-driver-extras</include>
+ <include>com.google.guava:guava</include>
Review comment:
guava is available, remove here
##########
File path: assemblies/plugins/transforms/cassandra/src/assembly/assembly.xml
##########
@@ -0,0 +1,60 @@
+<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3 http://maven.apache.org/xsd/assembly-1.1.3.xsd">
+ <id>hop-transform-cassandra</id>
+ <formats>
+ <format>zip</format>
+ </formats>
+ <baseDirectory>transforms/cassandra</baseDirectory>
+ <files>
+ <file>
+ <source>${project.basedir}/src/main/resources/version.xml</source>
+ <outputDirectory>.</outputDirectory>
+ <filtered>true</filtered>
+ </file>
+ </files>
+ <fileSets>
+ <fileSet>
+ <outputDirectory>lib</outputDirectory>
+ <excludes>
+ <exclude>**/*</exclude>
+ </excludes>
+ </fileSet>
+ </fileSets>
+ <dependencySets>
+ <dependencySet>
+ <useProjectArtifact>false</useProjectArtifact>
+ <includes>
+ <include>org.apache.hop:hop-transform-cassandra:jar</include>
+ </includes>
+ </dependencySet>
+ <dependencySet>
+ <outputDirectory>lib</outputDirectory>
+ <unpack>false</unpack>
+ <includes>
+ <include>org.apache.cassandra:cassandra-all</include>
+ <include>com.datastax.cassandra:cassandra-driver-core</include>
+ <include>com.datastax.cassandra:cassandra-driver-extras</include>
+ <include>com.google.guava:guava</include>
+ <include>com.boundary:high-scale-lib</include>
+ <include>com.github.jbellis:jamm</include>
+ <include>net.java.dev.jna:jna</include>
+ <include>org.apache.thrift:libthrift</include>
+ <include>net.jpountz.lz4:lz4</include>
+ <include>io.dropwizard.metrics:metrics-core</include>
+ <include>io.dropwizard.metrics:metrics-jvm</include>
+ <include>io.netty:netty-buffer</include>
+ <include>io.netty:netty-codec</include>
+ <include>io.netty:netty-common</include>
+ <include>io.netty:netty-handler</include>
+ <include>io.netty:netty-transport</include>
+ <include>org.fusesource:sigar</include>
+ <include>org.yaml:snakeyaml</include>
+ <include>com.clearspring.analytics:stream</include>
+ <include>net.sf.supercsv:super-csv</include>
+ <include>org.codehaus.jackson:jackson-core-asl</include>
+ <include>org.codehaus.jackson:jackson-mapper-asl</include>
Review comment:
jackson dependencies should be available in lib
##########
File path: plugins/transforms/cassandra/README.md
##########
@@ -0,0 +1 @@
+
Review comment:
readme is not needed you can remove this one
##########
File path: plugins/transforms/cassandra/src/main/java/org/apache/hop/databases/cassandra/spi/CQLRowHandler.java
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hop.databases.cassandra.spi;
+
+import java.util.Map;
+import org.apache.hop.core.logging.ILogChannel;
+import org.apache.hop.core.row.IRowMeta;
+import org.apache.hop.pipeline.transform.ITransform;
+
+/**
+ * Interface to something that can process rows (read and write) via CQL.
+ *
+ * @author Mark Hall (mhall{[at]}pentaho{[dot]}com)
Review comment:
remove
##########
File path: assemblies/plugins/transforms/cassandra/pom.xml
##########
@@ -0,0 +1,573 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.hop</groupId>
+ <artifactId>hop-assemblies-plugins-transforms</artifactId>
+ <version>0.50-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>hop-assemblies-plugins-transforms-cassandra</artifactId>
+ <packaging>pom</packaging>
+
+ <name>Hop Assemblies Plugins Transforms Cassandra</name>
+ <description></description>
+
+ <properties>
+ <!-- Test running configuration -->
+ <cassandra.version>3.11.1</cassandra.version>
+ <swt.version>4.6</swt.version>
+ <cassandra-driver.version>3.4.0</cassandra-driver.version>
+ <mockito.version>1.9.5</mockito.version>
+ <apache.commons.lang3.version>3.0</apache.commons.lang3.version>
+ <commons-lang.version>2.6</commons-lang.version>
+ <jface.version>3.3.0-I20070606-0010</jface.version>
+ <commons-xul.version>9.2.0.0-SNAPSHOT</commons-xul.version>
+ <guava.version>17.0</guava.version>
+ <snakeyaml.version>1.11</snakeyaml.version>
+ <netty.version>4.0.44.Final</netty.version>
+ <clearspring-stream.version>2.8.0</clearspring-stream.version>
+ <sigar.version>1.6.4</sigar.version>
+ <dropwizard-metrics.version>3.1.0</dropwizard-metrics.version>
+ <lz4.version>1.3.0</lz4.version>
+ <jna.version>4.0.0</jna.version>
+ <jamm.version>0.3.0</jamm.version>
+ <high-scale-lib.version>1.0.6</high-scale-lib.version>
+ <supercsv.version>2.1.0</supercsv.version>
+ <libthrift.version>0.12.0</libthrift.version>
+ <junit.version>4.11</junit.version>
+ </properties>
+
+<dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.eclipse.swt</groupId>
+ <artifactId>org.eclipse.swt.gtk.linux.x86_64</artifactId>
+ <version>${swt.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
Review comment:
SWT should not be needed here
##########
File path: assemblies/plugins/transforms/cassandra/pom.xml
##########
@@ -0,0 +1,573 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.hop</groupId>
+ <artifactId>hop-assemblies-plugins-transforms</artifactId>
+ <version>0.50-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>hop-assemblies-plugins-transforms-cassandra</artifactId>
+ <packaging>pom</packaging>
+
+ <name>Hop Assemblies Plugins Transforms Cassandra</name>
+ <description></description>
+
+ <properties>
+ <!-- Test running configuration -->
+ <cassandra.version>3.11.1</cassandra.version>
+ <swt.version>4.6</swt.version>
+ <cassandra-driver.version>3.4.0</cassandra-driver.version>
+ <mockito.version>1.9.5</mockito.version>
+ <apache.commons.lang3.version>3.0</apache.commons.lang3.version>
+ <commons-lang.version>2.6</commons-lang.version>
+ <jface.version>3.3.0-I20070606-0010</jface.version>
+ <commons-xul.version>9.2.0.0-SNAPSHOT</commons-xul.version>
+ <guava.version>17.0</guava.version>
+ <snakeyaml.version>1.11</snakeyaml.version>
+ <netty.version>4.0.44.Final</netty.version>
+ <clearspring-stream.version>2.8.0</clearspring-stream.version>
+ <sigar.version>1.6.4</sigar.version>
+ <dropwizard-metrics.version>3.1.0</dropwizard-metrics.version>
+ <lz4.version>1.3.0</lz4.version>
+ <jna.version>4.0.0</jna.version>
+ <jamm.version>0.3.0</jamm.version>
+ <high-scale-lib.version>1.0.6</high-scale-lib.version>
+ <supercsv.version>2.1.0</supercsv.version>
+ <libthrift.version>0.12.0</libthrift.version>
+ <junit.version>4.11</junit.version>
+ </properties>
+
+<dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.eclipse.swt</groupId>
+ <artifactId>org.eclipse.swt.gtk.linux.x86_64</artifactId>
+ <version>${swt.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse</groupId>
+ <artifactId>jface</artifactId>
+ <version>${jface.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.cassandra</groupId>
+ <artifactId>cassandra-all</artifactId>
+ <version>${cassandra.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>${guava.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.datastax.cassandra</groupId>
+ <artifactId>cassandra-driver-core</artifactId>
+ <version>${cassandra-driver.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.datastax.cassandra</groupId>
+ <artifactId>cassandra-driver-extras</artifactId>
+ <version>${cassandra-driver.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>commons-lang</groupId>
+ <artifactId>commons-lang</artifactId>
+ <version>${commons-lang.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>org.yaml</groupId>
+ <artifactId>snakeyaml</artifactId>
+ <version>${snakeyaml.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.boundary</groupId>
+ <artifactId>high-scale-lib</artifactId>
+ <version>${high-scale-lib.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.github.jbellis</groupId>
+ <artifactId>jamm</artifactId>
+ <version>${jamm.version}</version>
+ <scope>runtime</scope>
+ </dependency>
+ <dependency>
+ <groupId>net.java.dev.jna</groupId>
+ <artifactId>jna</artifactId>
+ <version>${jna.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>net.jpountz.lz4</groupId>
+ <artifactId>lz4</artifactId>
+ <version>${lz4.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>io.dropwizard.metrics</groupId>
+ <artifactId>metrics-core</artifactId>
+ <version>${dropwizard-metrics.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>io.dropwizard.metrics</groupId>
+ <artifactId>metrics-jvm</artifactId>
+ <version>${dropwizard-metrics.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.fusesource</groupId>
+ <artifactId>sigar</artifactId>
+ <version>${sigar.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.clearspring.analytics</groupId>
+ <artifactId>stream</artifactId>
+ <version>${clearspring-stream.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>net.sf.supercsv</groupId>
+ <artifactId>super-csv</artifactId>
+ <version>${supercsv.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.thrift</groupId>
+ <artifactId>libthrift</artifactId>
+ <version>${libthrift.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>${apache.commons.lang3.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-common</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-transport</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-buffer</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-codec</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-handler</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>pentaho-kettle</groupId>
+ <artifactId>kettle-engine</artifactId>
+ <version>${pdi.version}</version>
+ <classifier>tests</classifier>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>${junit.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-all</artifactId>
+ <version>${mockito.version}</version>
+ <scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
+ <version>${xml-apis.version}</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hop</groupId>
+ <artifactId>hop-transform-cassandra</artifactId>
+ <version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <artifactId>*</artifactId>
+ <groupId>*</groupId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.cassandra</groupId>
+ <artifactId>cassandra-all</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.datastax.cassandra</groupId>
+ <artifactId>cassandra-driver-core</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.datastax.cassandra</groupId>
+ <artifactId>cassandra-driver-extras</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
Review comment:
inherit from parent
##########
File path: plugins/transforms/cassandra/src/main/java/org/apache/hop/databases/cassandra/spi/Connection.java
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hop.databases.cassandra.spi;
+
+import java.util.Map;
+
+/**
+ * Interface for something that implements a connection to Cassandra
+ *
+ * @author Mark Hall (mhall{[at]}pentaho{[dot]}com)
Review comment:
remove
##########
File path: assemblies/plugins/transforms/cassandra/pom.xml
##########
@@ -0,0 +1,573 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.hop</groupId>
+ <artifactId>hop-assemblies-plugins-transforms</artifactId>
+ <version>0.50-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>hop-assemblies-plugins-transforms-cassandra</artifactId>
+ <packaging>pom</packaging>
+
+ <name>Hop Assemblies Plugins Transforms Cassandra</name>
+ <description></description>
+
+ <properties>
+ <!-- Test running configuration -->
+ <cassandra.version>3.11.1</cassandra.version>
+ <swt.version>4.6</swt.version>
+ <cassandra-driver.version>3.4.0</cassandra-driver.version>
+ <mockito.version>1.9.5</mockito.version>
+ <apache.commons.lang3.version>3.0</apache.commons.lang3.version>
+ <commons-lang.version>2.6</commons-lang.version>
+ <jface.version>3.3.0-I20070606-0010</jface.version>
+ <commons-xul.version>9.2.0.0-SNAPSHOT</commons-xul.version>
+ <guava.version>17.0</guava.version>
+ <snakeyaml.version>1.11</snakeyaml.version>
+ <netty.version>4.0.44.Final</netty.version>
+ <clearspring-stream.version>2.8.0</clearspring-stream.version>
+ <sigar.version>1.6.4</sigar.version>
+ <dropwizard-metrics.version>3.1.0</dropwizard-metrics.version>
+ <lz4.version>1.3.0</lz4.version>
+ <jna.version>4.0.0</jna.version>
+ <jamm.version>0.3.0</jamm.version>
+ <high-scale-lib.version>1.0.6</high-scale-lib.version>
+ <supercsv.version>2.1.0</supercsv.version>
+ <libthrift.version>0.12.0</libthrift.version>
+ <junit.version>4.11</junit.version>
+ </properties>
+
+<dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.eclipse.swt</groupId>
+ <artifactId>org.eclipse.swt.gtk.linux.x86_64</artifactId>
+ <version>${swt.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse</groupId>
+ <artifactId>jface</artifactId>
+ <version>${jface.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.cassandra</groupId>
+ <artifactId>cassandra-all</artifactId>
+ <version>${cassandra.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>${guava.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.datastax.cassandra</groupId>
+ <artifactId>cassandra-driver-core</artifactId>
+ <version>${cassandra-driver.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.datastax.cassandra</groupId>
+ <artifactId>cassandra-driver-extras</artifactId>
+ <version>${cassandra-driver.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>commons-lang</groupId>
+ <artifactId>commons-lang</artifactId>
+ <version>${commons-lang.version}</version>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>org.yaml</groupId>
+ <artifactId>snakeyaml</artifactId>
+ <version>${snakeyaml.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.boundary</groupId>
+ <artifactId>high-scale-lib</artifactId>
+ <version>${high-scale-lib.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.github.jbellis</groupId>
+ <artifactId>jamm</artifactId>
+ <version>${jamm.version}</version>
+ <scope>runtime</scope>
+ </dependency>
+ <dependency>
+ <groupId>net.java.dev.jna</groupId>
+ <artifactId>jna</artifactId>
+ <version>${jna.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>net.jpountz.lz4</groupId>
+ <artifactId>lz4</artifactId>
+ <version>${lz4.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>io.dropwizard.metrics</groupId>
+ <artifactId>metrics-core</artifactId>
+ <version>${dropwizard-metrics.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>io.dropwizard.metrics</groupId>
+ <artifactId>metrics-jvm</artifactId>
+ <version>${dropwizard-metrics.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.fusesource</groupId>
+ <artifactId>sigar</artifactId>
+ <version>${sigar.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>com.clearspring.analytics</groupId>
+ <artifactId>stream</artifactId>
+ <version>${clearspring-stream.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>net.sf.supercsv</groupId>
+ <artifactId>super-csv</artifactId>
+ <version>${supercsv.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.thrift</groupId>
+ <artifactId>libthrift</artifactId>
+ <version>${libthrift.version}</version>
+ <scope>runtime</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>${apache.commons.lang3.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-common</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-transport</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-buffer</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-codec</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-handler</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>pentaho-kettle</groupId>
+ <artifactId>kettle-engine</artifactId>
+ <version>${pdi.version}</version>
+ <classifier>tests</classifier>
+ <scope>test</scope>
+ </dependency>
Review comment:
remove
##########
File path: plugins/transforms/cassandra/src/main/java/org/apache/hop/databases/cassandra/util/CFMetaDataElements.java
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hop.databases.cassandra.util;
+
+/** Created by mracine on 2/6/2018. */
Review comment:
remove
##########
File path: plugins/transforms/cassandra/src/main/java/org/apache/hop/databases/cassandra/spi/ITableMetaData.java
##########
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hop.databases.cassandra.spi;
+
+import com.datastax.driver.core.DataType;
+import java.util.List;
+import org.apache.hop.core.row.IValueMeta;
+import org.apache.hop.databases.cassandra.util.Selector;
+
+/**
+ * Interface to something that can fetch and represent meta data on a Cassandra table
+ *
+ * @author Mark Hall (mhall{[at]}pentaho{[dot]}com)
Review comment:
remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mookkiah commented on pull request #427: WIP: Hop 2217
Posted by GitBox <gi...@apache.org>.
mookkiah commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-753602464
> I stopped halfway this needs quite a lot of changes before we can consider merging:
> 2 more points that worry me:
>
> * are all new included libraries a compatible license?
> * we should either create a database type for cassandra to store the metadata, or create a new metadata type to store the cassandra info, I do not like that all the fields are in the transform every time (prefered would be the second as regular database transforms can not use this meta)
```
Lists of 143 third-party dependencies.
(Eclipse Public License - v 1.0) (GNU Lesser General Public License) Logback Classic Module (ch.qos.logback:logback-classic:1.1.3 - http://logback.qos.ch/logback-classic)
(Eclipse Public License - v 1.0) (GNU Lesser General Public License) Logback Core Module (ch.qos.logback:logback-core:1.1.3 - http://logback.qos.ch/logback-core)
(Apache License, Version 2.0) metrics reporter config base (com.addthis.metrics:reporter-config-base:3.0.3 - https://github.com/addthis/metrics-reporter-config/reporter-config-base)
(Apache License, Version 2.0) metrics reporter config 3.x (com.addthis.metrics:reporter-config3:3.0.3 - https://github.com/addthis/metrics-reporter-config/reporter-config3)
(MIT License) high-scale-lib (com.boundary:high-scale-lib:1.0.6 - https://github.com/boundary/high-scale-lib)
(The Apache Software License, Version 2.0) HPPC Collections (com.carrotsearch:hppc:0.5.4 - http://labs.carrotsearch.com/hppc.html/hppc)
(Apache License, Version 2.0) stream-lib (com.clearspring.analytics:stream:2.8.0 - https://github.com/addthis/stream-lib)
(Apache 2) DataStax Java Driver for Apache Cassandra - Core (com.datastax.cassandra:cassandra-driver-core:3.4.0 - https://github.com/datastax/java-driver/cassandra-driver-core)
(Apache 2) DataStax Java Driver for Apache Cassandra - Extras (com.datastax.cassandra:cassandra-driver-extras:3.4.0 - https://github.com/datastax/java-driver/cassandra-driver-extras)
(The Apache Software License, Version 2.0) Jackson-annotations (com.fasterxml.jackson.core:jackson-annotations:2.10.2 - http://github.com/FasterXML/jackson)
(The Apache Software License, Version 2.0) Jackson-core (com.fasterxml.jackson.core:jackson-core:2.10.2 - https://github.com/FasterXML/jackson-core)
(The Apache Software License, Version 2.0) jackson-databind (com.fasterxml.jackson.core:jackson-databind:2.10.2 - http://github.com/FasterXML/jackson)
(The Apache Software License, Version 2.0) Caffeine cache (com.github.ben-manes.caffeine:caffeine:2.2.6 - https://github.com/ben-manes/caffeine)
(The Apache Software License, Version 2.0) Java Agent for Memory Measurements (com.github.jbellis:jamm:0.3.0 - https://github.com/jbellis/jamm/)
(The Apache Software License, Version 2.0) jffi (com.github.jnr:jffi:1.2.10 - http://github.com/jnr/jffi)
(The Apache Software License, Version 2.0) jnr-constants (com.github.jnr:jnr-constants:0.9.0 - http://github.com/jnr/jnr-constants)
(The Apache Software License, Version 2.0) jnr-ffi (com.github.jnr:jnr-ffi:2.0.7 - http://github.com/jnr/jnr-ffi)
(Common Public License - v 1.0) (GNU General Public License Version 2) (GNU Lesser General Public License Version 2.1) jnr-posix (com.github.jnr:jnr-posix:3.0.27 - http://nexus.sonatype.org/oss-repository-hosting.html/jnr-posix)
(MIT License) jnr-x86asm (com.github.jnr:jnr-x86asm:1.0.2 - http://github.com/jnr/jnr-x86asm)
(BSD License) snowball-stemmer (com.github.rholder:snowball-stemmer:1.3.0.581.1 - http://snowball.tartarus.org/)
(Apache 2.0) Gson (com.google.code.gson:gson:2.8.5 - https://github.com/google/gson/gson)
(The Apache Software License, Version 2.0) Guava: Google Core Libraries for Java (com.google.guava:guava:27.0-jre - https://github.com/google/guava/guava)
(The Apache Software License, Version 2.0) Concurrent-Trees (com.googlecode.concurrent-trees:concurrent-trees:2.4.0 - http://code.google.com/p/concurrent-trees/)
(The Apache Software License, Version 2.0) ConcurrentLinkedHashMap (com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4 - http://code.google.com/p/concurrentlinkedhashmap)
(The Apache Software License, Version 2.0) JSON.simple (com.googlecode.json-simple:json-simple:1.1 - http://code.google.com/p/json-simple/)
(Revised BSD) JSch (com.jcraft:jsch:0.1.54 - http://www.jcraft.com/jsch/)
(BSD) JZlib (com.jcraft:jzlib:1.0.7 - http://www.jcraft.com/jzlib/)
(The Apache Software License, Version 2.0) Disruptor Framework (com.lmax:disruptor:3.0.1 - http://lmax-exchange.github.com/disruptor)
(Apache License 2.0) Ning-compress-LZF (com.ning:compress-lzf:0.8.4 - http://github.com/ning/compress)
(CDDL 1.1) (GPL2 w/ CPE) jersey-bundle (com.sun.jersey:jersey-bundle:1.19.1 - https://jersey.java.net/jersey-bundle/)
(CDDL 1.1) (GPL2 w/ CPE) Jersey Apache HTTP Client 4.x (com.sun.jersey.contribs:jersey-apache-client4:1.19.1 - https://jersey.java.net/jersey-contribs/jersey-apache-client4/)
(Apache 2) Thrift Server implementation backed by LMAX Disruptor (com.thinkaurelius.thrift:thrift-server:0.3.7 - http://github.com/xedin/disruptor_thrift_server)
(Apache License, Version 2.0) Apache Commons BeanUtils (commons-beanutils:commons-beanutils:1.9.4 - https://commons.apache.org/proper/commons-beanutils/)
(The Apache Software License, Version 2.0) CLI (commons-cli:commons-cli:1.1 - http://jakarta.apache.org/commons/cli/)
(Apache License, Version 2.0) Apache Commons Codec (commons-codec:commons-codec:1.10 - http://commons.apache.org/proper/commons-codec/)
(Apache License, Version 2.0) Apache Commons Collections (commons-collections:commons-collections:3.2.2 - http://commons.apache.org/collections/)
(The Apache Software License, Version 2.0) Commons DBCP (commons-dbcp:commons-dbcp:1.4 - http://commons.apache.org/dbcp/)
(The Apache Software License, Version 2.0) Commons IO (commons-io:commons-io:2.2 - http://commons.apache.org/io/)
(The Apache Software License, Version 2.0) Commons Lang (commons-lang:commons-lang:2.6 - http://commons.apache.org/lang/)
(The Apache Software License, Version 2.0) Commons Logging (commons-logging:commons-logging:1.1.3 - http://commons.apache.org/proper/commons-logging/)
(The Apache Software License, Version 2.0) Commons Pool (commons-pool:commons-pool:1.5.7 - http://commons.apache.org/pool/)
(The Apache Software License, Version 2.0) Validator (commons-validator:commons-validator:1.3.1 - http://jakarta.apache.org/commons/${pom.artifactId.substring(8)}/)
(BSD) JFlex (de.jflex:jflex:1.6.0 - http://jflex.de/)
(The Apache Software License, version 2.0) picocli - a mighty tiny Command Line Interface (info.picocli:picocli:3.7.0 - http://picocli.info)
(Apache License 2.0) Metrics Core (io.dropwizard.metrics:metrics-core:3.1.0 - http://metrics.codahale.com/metrics-core/)
(Apache License 2.0) JVM Integration for Metrics (io.dropwizard.metrics:metrics-jvm:3.1.0 - http://metrics.codahale.com/metrics-jvm/)
(Apache License, Version 2.0) Netty/All-in-One (io.netty:netty-all:4.0.44.Final - http://netty.io/netty-all/)
(Apache License, Version 2.0) Netty/Buffer (io.netty:netty-buffer:4.0.44.Final - http://netty.io/netty-buffer/)
(Apache License, Version 2.0) Netty/Codec (io.netty:netty-codec:4.0.44.Final - http://netty.io/netty-codec/)
(Apache License, Version 2.0) Netty/Common (io.netty:netty-common:4.0.44.Final - http://netty.io/netty-common/)
(Apache License, Version 2.0) Netty/Handler (io.netty:netty-handler:4.0.44.Final - http://netty.io/netty-handler/)
(Apache License, Version 2.0) Netty/Transport (io.netty:netty-transport:4.0.44.Final - http://netty.io/netty-transport/)
(CDDL + GPLv2 with classpath exception) javax.annotation API (javax.annotation:javax.annotation-api:1.2 - http://jcp.org/en/jsr/detail?id=250)
(CDDL + GPLv2 with classpath exception) Java Servlet API (javax.servlet:javax.servlet-api:3.1.0 - http://servlet-spec.java.net)
(Apache License, Version 2.0) Bean Validation API (javax.validation:validation-api:1.0.0.GA - no url defined)
(Apache 2) Joda-Time (joda-time:joda-time:2.4 - http://www.joda.org/joda-time/)
(Common Public License Version 1.0) JUnit (junit:junit:4.11 - http://junit.org)
(The Apache Software License, Version 2.0) Apache Log4j (log4j:log4j:1.2.17 - http://logging.apache.org/log4j/1.2/)
(ASL, version 2) (LGPL, version 2.1) Java Native Access (net.java.dev.jna:jna:4.0.0 - https://github.com/twall/jna)
(The Apache Software License, Version 2.0) LZ4 and xxHash (net.jpountz.lz4:lz4:1.3.0 - https://github.com/jpountz/lz4-java)
(BSD License) OGNL (ognl:ognl:2.6.9 - http://www.ognl.org/)
(BSD licence) StringTemplate 4 (org.antlr:ST4:4.0.8 - http://www.stringtemplate.org)
(BSD licence) ANTLR 3 Tool (org.antlr:antlr:3.5.2 - http://antlr.org/antlr)
(BSD licence) ANTLR 3 Runtime (org.antlr:antlr-runtime:3.5.2 - http://www.antlr.org)
(Unknown license) org.apache.tools.ant (org.apache.ant:ant:1.7.0 - http://ant.apache.org/ant/)
(Unknown license) ant-launcher (org.apache.ant:ant-launcher:1.7.0 - http://ant.apache.org/ant-launcher/)
(The Apache Software License, Version 2.0) Apache Cassandra (org.apache.cassandra:cassandra-all:3.11.1 - http://cassandra.apache.org)
(The Apache Software License, Version 2.0) Apache Cassandra (org.apache.cassandra:cassandra-thrift:3.11.1 - http://cassandra.apache.org)
(Apache License, Version 2.0) Apache Commons Compress (org.apache.commons:commons-compress:1.19 - https://commons.apache.org/proper/commons-compress/)
(The Apache Software License, Version 2.0) Commons Lang (org.apache.commons:commons-lang3:3.0 - http://commons.apache.org/lang/)
(The Apache Software License, Version 2.0) Commons Math (org.apache.commons:commons-math3:3.2 - http://commons.apache.org/proper/commons-math/)
(Apache License, Version 2.0) Apache Commons VFS (org.apache.commons:commons-vfs2:2.4.1 - http://commons.apache.org/proper/commons-vfs/)
(Apache License, Version 2.0) (GNU Lesser General Public License, Version 2.1) (GNU Lesser General Public License, Version 3.0) Hop Core (org.apache.hop:hop-core:0.60-SNAPSHOT - https://hop.apache.org/hop-core)
(Apache License, Version 2.0) (GNU Lesser General Public License, Version 2.1) (GNU Lesser General Public License, Version 3.0) Hop Engine (org.apache.hop:hop-engine:0.60-SNAPSHOT - https://hop.apache.org/hop-engine)
(Apache License, Version 2.0) (GNU Lesser General Public License, Version 2.1) (GNU Lesser General Public License, Version 3.0) Hop GUI (org.apache.hop:hop-ui:0.60-SNAPSHOT - https://hop.apache.org/hop-ui)
(Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.3 - http://hc.apache.org/httpcomponents-client)
(Apache License, Version 2.0) Apache HttpCore (org.apache.httpcomponents:httpcore:4.4.6 - http://hc.apache.org/httpcomponents-core-ga)
(The Apache Software License, Version 2.0) Apache Thrift (org.apache.thrift:libthrift:0.12.0 - http://thrift.apache.org)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-anim (org.apache.xmlgraphics:batik-anim:1.12 - http://xmlgraphics.apache.org/batik/batik-anim/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-awt-util (org.apache.xmlgraphics:batik-awt-util:1.12 - http://xmlgraphics.apache.org/batik/batik-awt-util/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-bridge (org.apache.xmlgraphics:batik-bridge:1.12 - http://xmlgraphics.apache.org/batik/batik-bridge/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-codec (org.apache.xmlgraphics:batik-codec:1.12 - http://xmlgraphics.apache.org/batik/batik-codec/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-constants (org.apache.xmlgraphics:batik-constants:1.12 - http://xmlgraphics.apache.org/batik/batik-constants/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-css (org.apache.xmlgraphics:batik-css:1.12 - http://xmlgraphics.apache.org/batik/batik-css/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-dom (org.apache.xmlgraphics:batik-dom:1.12 - http://xmlgraphics.apache.org/batik/batik-dom/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-ext (org.apache.xmlgraphics:batik-ext:1.12 - http://xmlgraphics.apache.org/batik/batik-ext/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-gvt (org.apache.xmlgraphics:batik-gvt:1.12 - http://xmlgraphics.apache.org/batik/batik-gvt/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-i18n (org.apache.xmlgraphics:batik-i18n:1.12 - http://xmlgraphics.apache.org/batik/batik-i18n/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-parser (org.apache.xmlgraphics:batik-parser:1.12 - http://xmlgraphics.apache.org/batik/batik-parser/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-script (org.apache.xmlgraphics:batik-script:1.12 - http://xmlgraphics.apache.org/batik/batik-script/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-svg-dom (org.apache.xmlgraphics:batik-svg-dom:1.12 - http://xmlgraphics.apache.org/batik/batik-svg-dom/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-svggen (org.apache.xmlgraphics:batik-svggen:1.12 - http://xmlgraphics.apache.org/batik/batik-svggen/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-transcoder (org.apache.xmlgraphics:batik-transcoder:1.12 - http://xmlgraphics.apache.org/batik/batik-transcoder/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-util (org.apache.xmlgraphics:batik-util:1.12 - http://xmlgraphics.apache.org/batik/batik-util/)
(The Apache Software License, Version 2.0) org.apache.xmlgraphics:batik-xml (org.apache.xmlgraphics:batik-xml:1.12 - http://xmlgraphics.apache.org/batik/batik-xml/)
(Apache 2) OHC core (org.caffinitas.ohc:ohc-core:0.4.4 - http://caffinitas.org/)
(The Apache Software License, Version 2.0) Jackson (org.codehaus.jackson:jackson-core-asl:1.9.13 - http://jackson.codehaus.org)
(The Apache Software License, Version 2.0) Data Mapper for Jackson (org.codehaus.jackson:jackson-mapper-asl:1.9.13 - http://jackson.codehaus.org)
(BSD 3-clause New License) dom4j (org.dom4j:dom4j:2.1.3 - http://dom4j.github.io/)
(Eclipse Public License v1.0) Eclipse ECJ (org.eclipse.jdt.core.compiler:ecj:4.4.2 - http://www.eclipse.org/jdt/)
(Apache Software License - Version 2.0) (Eclipse Public License - Version 1.0) Jetty :: Http Utility (org.eclipse.jetty:jetty-http:9.4.24.v20191120 - http://www.eclipse.org/jetty)
(Apache Software License - Version 2.0) (Eclipse Public License - Version 1.0) Jetty :: IO Utility (org.eclipse.jetty:jetty-io:9.4.24.v20191120 - http://www.eclipse.org/jetty)
(Apache Software License - Version 2.0) (Eclipse Public License - Version 1.0) Jetty :: JAAS (org.eclipse.jetty:jetty-jaas:9.4.22.v20191022 - https://eclipse.org/jetty/jetty-jaas)
(Apache Software License - Version 2.0) (Eclipse Public License - Version 1.0) Jetty :: Security (org.eclipse.jetty:jetty-security:9.4.22.v20191022 - http://www.eclipse.org/jetty)
(Apache Software License - Version 2.0) (Eclipse Public License - Version 1.0) Jetty :: Server Core (org.eclipse.jetty:jetty-server:9.4.24.v20191120 - http://www.eclipse.org/jetty)
(Apache Software License - Version 2.0) (Eclipse Public License - Version 1.0) Jetty :: Servlet Handling (org.eclipse.jetty:jetty-servlet:9.4.22.v20191022 - http://www.eclipse.org/jetty)
(Apache Software License - Version 2.0) (Eclipse Public License - Version 1.0) Jetty :: Utility Servlets and Filters (org.eclipse.jetty:jetty-servlets:9.4.22.v20191022 - http://www.eclipse.org/jetty)
(Apache Software License - Version 2.0) (Eclipse Public License - Version 1.0) Jetty :: Utilities (org.eclipse.jetty:jetty-util:9.4.22.v20191022 - http://www.eclipse.org/jetty)
(Apache Software License - Version 2.0) (Eclipse Public License - Version 1.0) Jetty :: Webapp Application Support (org.eclipse.jetty:jetty-webapp:9.4.34.v20201102 - https://eclipse.org/jetty/jetty-webapp)
(Apache Software License - Version 2.0) (Eclipse Public License - Version 1.0) Jetty :: XML utilities (org.eclipse.jetty:jetty-xml:9.4.22.v20191022 - http://www.eclipse.org/jetty)
(Eclipse Public License - v 2.0) Commands (org.eclipse.platform:org.eclipse.core.commands:3.9.600 - http://www.eclipse.org/platform)
(Eclipse Public License - v 2.0) Common Eclipse Runtime (org.eclipse.platform:org.eclipse.equinox.common:3.10.600 - http://www.eclipse.org/platform)
(Eclipse Public License - v 2.0) JFace (org.eclipse.platform:org.eclipse.jface:3.18.0 - http://www.eclipse.org/platform)
(Eclipse Public License - v 2.0) Standard Widget Toolkit for Mac OS X (Cocoa) (org.eclipse.platform:org.eclipse.swt.cocoa.macosx.x86_64:3.114.0 - http://www.eclipse.org/platform)
(The Apache Software License, Version 2.0) sigar (org.fusesource:sigar:1.6.4 - http://fusesource.com/sigar/)
(CDDL+GPL License) Metro Web Services API non-OSGi Bundle (org.glassfish.metro:webservices-api:2.3.1 - http://metro.java.net/bundles/webservices-api/)
(New BSD License) Hamcrest Core (org.hamcrest:hamcrest-core:1.3 - https://github.com/hamcrest/JavaHamcrest/hamcrest-core)
(GNU Lesser General Public License) Hibernate Core (org.hibernate:hibernate-core:3.6.9.Final - http://hibernate.org/hibernate-core)
(Apache License, Version 2.0) Hibernate Validator Engine (org.hibernate:hibernate-validator:4.3.0.Final - http://validator.hibernate.org/hibernate-validator)
(Apache License 2.0) (LGPL 2.1) (MPL 1.1) Javassist (org.javassist:javassist:3.20.0-GA - http://www.javassist.org/)
(Apache License, Version 2.0) Java Annotation Indexer (org.jboss:jandex:2.2.2.Final - http://www.jboss.org/jandex)
(GNU Lesser General Public License, version 2.1) JBoss Logging 3 (org.jboss.logging:jboss-logging:3.1.0.CR2 - http://www.jboss.org)
(Apache License, Version 2.0) Java Concurrency Tools Core Library (org.jctools:jctools-core:1.2.1 - https://github.com/JCTools)
(ISC/BSD License) jbcrypt (org.mindrot:jbcrypt:0.3m - http://www.mindrot.org/)
(The MIT License) Mockito (org.mockito:mockito-all:1.9.5 - http://www.mockito.org)
(Mozilla Public License, Version 2.0) Mozilla Rhino (org.mozilla:rhino:1.7.12 - https://developer.mozilla.org/en/Rhino)
(BSD) ASM Core (org.ow2.asm:asm:5.0.3 - http://asm.objectweb.org/asm/)
(BSD) ASM Analysis (org.ow2.asm:asm-analysis:5.0.3 - http://asm.objectweb.org/asm-analysis/)
(BSD) ASM Commons (org.ow2.asm:asm-commons:5.0.3 - http://asm.objectweb.org/asm-commons/)
(BSD) ASM Tree (org.ow2.asm:asm-tree:5.0.3 - http://asm.objectweb.org/asm-tree/)
(BSD) ASM Util (org.ow2.asm:asm-util:5.0.3 - http://asm.objectweb.org/asm-util/)
(The BSD 3-Clause License) OWASP Encoders (org.owasp.encoder:encoder:1.2 - https://www.owasp.org/index.php/OWASP_Java_Encoder_Project/encoder)
(MIT License) JCL 1.1.1 implemented over SLF4J (org.slf4j:jcl-over-slf4j:1.7.7 - http://www.slf4j.org)
(Apache Software Licenses) Log4j Implemented Over SLF4J (org.slf4j:log4j-over-slf4j:1.7.7 - http://www.slf4j.org)
(MIT License) SLF4J API Module (org.slf4j:slf4j-api:1.7.7 - http://www.slf4j.org)
(MIT License) SLF4J LOG4J-12 Binding (org.slf4j:slf4j-log4j12:1.7.30 - http://www.slf4j.org)
(The Apache Software License, Version 2.0) Spring Core (org.springframework:spring-core:4.3.2.RELEASE - https://github.com/spring-projects/spring-framework)
(The Apache Software License, Version 2.0) Spring TestContext Framework (org.springframework:spring-test:4.3.2.RELEASE - https://github.com/spring-projects/spring-framework)
(The Apache Software License, Version 2.0) snappy-java (org.xerial.snappy:snappy-java:1.1.1.7 - https://github.comm/xerial/snappy-java)
(Apache License Version 2.0) SnakeYAML (org.yaml:snakeyaml:1.11 - http://www.snakeyaml.org)
(The Apache Software License, Version 2.0) Xerces2-j (xerces:xercesImpl:2.12.0 - https://xerces.apache.org/xerces2-j/)
(The Apache Software License, Version 2.0) (The SAX License) (The W3C License) XML Commons External Components XML APIs (xml-apis:xml-apis:1.4.01 - http://xml.apache.org/commons/components/external/)
(The Apache Software License, Version 2.0) XML Commons External Components XML APIs Extensions (xml-apis:xml-apis-ext:1.3.04 - http://xml.apache.org/commons/components/external/)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #427: WIP: Hop 2217
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-739167369
my excuses, pressed the wrong button :sweat_smile:
I'll see if I can find some time to check the rest of the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mookkiah commented on pull request #427: Hop 2217
Posted by GitBox <gi...@apache.org>.
mookkiah commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-739257398
Now the code is in good state but may not function. I will work on the breaking functions in future PR.
If code is good to merge, please go ahead. If not I can put it back to WIP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva edited a comment on pull request #427: Hop 2217
Posted by GitBox <gi...@apache.org>.
hansva edited a comment on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-752737860
I stopped halfway this needs quite a lot of changes before we can consider merging:
2 more points that worry me:
- are all new included libraries a compatible license?
- we should either create a database type for cassandra to store the metadata, or create a new metadata type to store the cassandra info, I do not like that all the fields are in the transform every time (prefered would be the second as regular database transforms can not use this meta)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mookkiah commented on a change in pull request #427: WIP: Hop 2217
Posted by GitBox <gi...@apache.org>.
mookkiah commented on a change in pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#discussion_r550940418
##########
File path: assemblies/plugins/transforms/cassandra/pom.xml
##########
@@ -0,0 +1,573 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.hop</groupId>
+ <artifactId>hop-assemblies-plugins-transforms</artifactId>
+ <version>0.50-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>hop-assemblies-plugins-transforms-cassandra</artifactId>
+ <packaging>pom</packaging>
+
+ <name>Hop Assemblies Plugins Transforms Cassandra</name>
+ <description></description>
+
+ <properties>
+ <!-- Test running configuration -->
+ <cassandra.version>3.11.1</cassandra.version>
+ <swt.version>4.6</swt.version>
+ <cassandra-driver.version>3.4.0</cassandra-driver.version>
+ <mockito.version>1.9.5</mockito.version>
+ <apache.commons.lang3.version>3.0</apache.commons.lang3.version>
+ <commons-lang.version>2.6</commons-lang.version>
+ <jface.version>3.3.0-I20070606-0010</jface.version>
+ <commons-xul.version>9.2.0.0-SNAPSHOT</commons-xul.version>
+ <guava.version>17.0</guava.version>
Review comment:
removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mookkiah commented on pull request #427: WIP: HOP-2217
Posted by GitBox <gi...@apache.org>.
mookkiah commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-761445768
> Hi @mookkiah I've set up my Cassandra test environment. First thing I tried is the Cassandra Output transform.
> I usually test the connection with the "Get table names" button on the "Write options" tab but I'm getting a NCDFE:
>
> java.lang.NoClassDefFoundError: Could not initialize class com.datastax.driver.core.Cluster
> at org.apache.hop.databases.cassandra.driver.datastax.DriverConnection.getCluster(DriverConnection.java:123)
> at org.apache.hop.databases.cassandra.driver.datastax.DriverConnection.getKeyspace(DriverConnection.java:147)
> at org.apache.hop.pipeline.transforms.cassandraoutput.CassandraOutputDialog.setupTablesCombo(CassandraOutputDialog.java:1115)
> at org.apache.hop.pipeline.transforms.cassandraoutput.CassandraOutputDialog$6.widgetSelected(CassandraOutputDialog.java:438)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:252)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5687)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1423)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4955)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4448)
> at org.apache.hop.pipeline.transforms.cassandraoutput.CassandraOutputDialog.open(CassandraOutputDialog.java:1078)
> at org.apache.hop.ui.hopgui.file.pipeline.delegates.HopGuiPipelineTransformDelegate.editTransform(HopGuiPipelineTransformDelegate.java:161)
> at org.apache.hop.ui.hopgui.file.pipeline.HopGuiPipelineGraph.editTransform(HopGuiPipelineGraph.java:3215)
> at org.apache.hop.ui.hopgui.file.pipeline.HopGuiPipelineGraph.mouseUp(HopGuiPipelineGraph.java:877)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:224)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5687)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1423)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4955)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4448)
> at org.apache.hop.ui.hopgui.HopGui.open(HopGui.java:376)
> at org.apache.hop.ui.hopgui.HopGui.main(HopGui.java:312)
This problem resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #427: WIP: Hop 2217
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-739166124
> > one note, we should change it in the main pom too...
> > The header has to be:
> > ```
> > /*
> > * Licensed to the Apache Software Foundation (ASF) under one or more
> > * contributor license agreements. See the NOTICE file distributed with
> > * this work for additional information regarding copyright ownership.
> > * The ASF licenses this file to You under the Apache License, Version 2.0
> > * (the "License"); you may not use this file except in compliance with
> > * the License. You may obtain a copy of the License at
> > *
> > * http://www.apache.org/licenses/LICENSE-2.0
> > *
> > * Unless required by applicable law or agreed to in writing, software
> > * distributed under the License is distributed on an "AS IS" BASIS,
> > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> > * See the License for the specific language governing permissions and
> > * limitations under the License.
> > */
> > ```
> >
> >
> > bit of an adjusted header for ASF projects
>
> license adjusted in parent pom and spotless applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mookkiah commented on a change in pull request #427: WIP: Hop 2217
Posted by GitBox <gi...@apache.org>.
mookkiah commented on a change in pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#discussion_r550940587
##########
File path: plugins/transforms/cassandra/src/main/java/org/apache/hop/databases/cassandra/spi/CQLRowHandler.java
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hop.databases.cassandra.spi;
+
+import java.util.Map;
+import org.apache.hop.core.logging.ILogChannel;
+import org.apache.hop.core.row.IRowMeta;
+import org.apache.hop.pipeline.transform.ITransform;
+
+/**
+ * Interface to something that can process rows (read and write) via CQL.
+ *
+ * @author Mark Hall (mhall{[at]}pentaho{[dot]}com)
Review comment:
removed author from all files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva edited a comment on pull request #427: WIP: Hop 2217
Posted by GitBox <gi...@apache.org>.
hansva edited a comment on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-739166124
> > one note, we should change it in the main pom too...
> > The header has to be:
> > ```
> > /*
> > * Licensed to the Apache Software Foundation (ASF) under one or more
> > * contributor license agreements. See the NOTICE file distributed with
> > * this work for additional information regarding copyright ownership.
> > * The ASF licenses this file to You under the Apache License, Version 2.0
> > * (the "License"); you may not use this file except in compliance with
> > * the License. You may obtain a copy of the License at
> > *
> > * http://www.apache.org/licenses/LICENSE-2.0
> > *
> > * Unless required by applicable law or agreed to in writing, software
> > * distributed under the License is distributed on an "AS IS" BASIS,
> > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> > * See the License for the specific language governing permissions and
> > * limitations under the License.
> > */
> > ```
> >
> >
> > bit of an adjusted header for ASF projects
>
> license adjusted in parent pom and spotless applied.
thank @mookkiah
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mookkiah commented on pull request #427: WIP: Hop 2217
Posted by GitBox <gi...@apache.org>.
mookkiah commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-739163690
> one note, we should change it in the main pom too...
> The header has to be:
>
> ```
> /*
> * Licensed to the Apache Software Foundation (ASF) under one or more
> * contributor license agreements. See the NOTICE file distributed with
> * this work for additional information regarding copyright ownership.
> * The ASF licenses this file to You under the Apache License, Version 2.0
> * (the "License"); you may not use this file except in compliance with
> * the License. You may obtain a copy of the License at
> *
> * http://www.apache.org/licenses/LICENSE-2.0
> *
> * Unless required by applicable law or agreed to in writing, software
> * distributed under the License is distributed on an "AS IS" BASIS,
> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> * See the License for the specific language governing permissions and
> * limitations under the License.
> */
> ```
>
> bit of an adjusted header for ASF projects
license adjusted in parent pom and spotless applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mookkiah commented on pull request #427: WIP: HOP-2217
Posted by GitBox <gi...@apache.org>.
mookkiah commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-759190584
@mattcasters I will check this on weekend. The jar might have excluded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva closed pull request #427: WIP: HOP-2217
Posted by GitBox <gi...@apache.org>.
hansva closed pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mookkiah commented on pull request #427: WIP: HOP-2217
Posted by GitBox <gi...@apache.org>.
mookkiah commented on pull request #427:
URL: https://github.com/apache/incubator-hop/pull/427#issuecomment-761292274
Note to myself: This [branch](https://github.com/mookkiah/hop/tree/hop-2217-jan02) is working
applying review comments step by step to figure out which change is breaking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org