You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/11/20 20:28:10 UTC

[commons-beanutils] branch master updated: Use a switch instead of a cascading if-else.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git


The following commit(s) were added to refs/heads/master by this push:
     new d9ceea7  Use a switch instead of a cascading if-else.
d9ceea7 is described below

commit d9ceea77b8bdcbc0e3c9d2d4a04cc383f460ec7e
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Nov 20 15:28:06 2020 -0500

    Use a switch instead of a cascading if-else.
---
 .../apache/commons/beanutils2/expression/DefaultResolver.java | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/beanutils2/expression/DefaultResolver.java b/src/main/java/org/apache/commons/beanutils2/expression/DefaultResolver.java
index 32e30d8..6f23ccb 100644
--- a/src/main/java/org/apache/commons/beanutils2/expression/DefaultResolver.java
+++ b/src/main/java/org/apache/commons/beanutils2/expression/DefaultResolver.java
@@ -239,12 +239,17 @@ public class DefaultResolver implements Resolver {
                     return expression.substring(0, i + 1);
                 }
             } else {
-                if (c == NESTED) {
+                switch (c) {
+                case NESTED:
                     return expression.substring(0, i);
-                } else if (c == MAPPED_START) {
+                case MAPPED_START:
                     mapped = true;
-                } else if (c == INDEXED_START) {
+                    break;
+                case INDEXED_START:
                     indexed = true;
+                    break;
+                default:
+                    break;
                 }
             }
         }