You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/03 01:52:03 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #484: use requirements.txt to formalize python deps
Jimexist opened a new pull request #484:
URL: https://github.com/apache/arrow-datafusion/pull/484
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #484: use requirements.txt to formalize python deps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #484:
URL: https://github.com/apache/arrow-datafusion/pull/484#issuecomment-853507337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #484: use requirements.txt to formalize python deps
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #484:
URL: https://github.com/apache/arrow-datafusion/pull/484#issuecomment-853840953
> Looks great. Great to see pip-tools being used :)
>
>
>
> What do you think about adding to the README how to update test dependencies? Something like
>
>
>
> > To change test dependencies, change the `requirements.in` and run
>
> > ```
>
> > # change requirements.in
>
> > pip install pip-tools
>
> > pip-compile --generate-hashes
>
> > ```
>
> >
>
> > To update dependencies, run
>
> > ```
>
> > pip-compile update
>
> > ```
>
> > More details [here](https://github.com/jazzband/pip-tools)
>
>
Personally I lean towards using poetry but that demands changes to publishing procedures as well - what do you think of that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #484: use requirements.txt to formalize python deps
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #484:
URL: https://github.com/apache/arrow-datafusion/pull/484#issuecomment-853507337
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#484](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b142ed8) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/33ff660318bf60d0c9aa45ceba2c4c943bfe9438?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33ff660) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #484 +/- ##
=======================================
Coverage 75.80% 75.80%
=======================================
Files 153 153
Lines 25924 25924
=======================================
Hits 19652 19652
Misses 6272 6272
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33ff660...b142ed8](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #484: use requirements.txt to formalize python deps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #484:
URL: https://github.com/apache/arrow-datafusion/pull/484#issuecomment-853507337
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#484](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfef5af) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/e713bc3b33fc4483eaf799b1c4cca355ca421f3c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e713bc3) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #484 +/- ##
=======================================
Coverage 75.95% 75.95%
=======================================
Files 154 154
Lines 26349 26349
=======================================
Hits 20014 20014
Misses 6335 6335
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e713bc3...dfef5af](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #484: use requirements.txt to formalize python deps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #484:
URL: https://github.com/apache/arrow-datafusion/pull/484#issuecomment-853507337
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#484](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68bd698) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/33ff660318bf60d0c9aa45ceba2c4c943bfe9438?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33ff660) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #484 +/- ##
==========================================
+ Coverage 75.80% 75.92% +0.12%
==========================================
Files 153 154 +1
Lines 25924 26195 +271
==========================================
+ Hits 19652 19889 +237
- Misses 6272 6306 +34
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/src/execution/context.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvZXhlY3V0aW9uL2NvbnRleHQucnM=) | `92.08% <0.00%> (ø)` | |
| [datafusion/src/physical\_plan/functions.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvcGh5c2ljYWxfcGxhbi9mdW5jdGlvbnMucnM=) | `92.70% <0.00%> (ø)` | |
| [datafusion/src/optimizer/simplify\_expressions.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvb3B0aW1pemVyL3NpbXBsaWZ5X2V4cHJlc3Npb25zLnJz) | `87.45% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33ff660...68bd698](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #484: use requirements.txt to formalize python deps
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #484:
URL: https://github.com/apache/arrow-datafusion/pull/484#issuecomment-853507337
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#484](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b142ed8) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/33ff660318bf60d0c9aa45ceba2c4c943bfe9438?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33ff660) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #484 +/- ##
=======================================
Coverage 75.80% 75.80%
=======================================
Files 153 153
Lines 25924 25924
=======================================
Hits 19652 19652
Misses 6272 6272
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33ff660...b142ed8](https://codecov.io/gh/apache/arrow-datafusion/pull/484?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #484: use requirements.txt to formalize python deps
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #484:
URL: https://github.com/apache/arrow-datafusion/pull/484#issuecomment-853840953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #484: use requirements.txt to formalize python deps
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #484:
URL: https://github.com/apache/arrow-datafusion/pull/484#issuecomment-853995675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #484: use requirements.txt to formalize python deps
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #484:
URL: https://github.com/apache/arrow-datafusion/pull/484#issuecomment-853879203
I do not quite follow: AFAIK both pip-tools and poetry are tools for Python applications, not Python libraries. For libraries, we only need to provide a `setup.py / project.toml`, which madurin does for us. I.e. the `install_requires` is [here](https://github.com/apache/arrow-datafusion/blob/master/python/Cargo.toml#L41).
AFAI understand this PR is only concerned with the dependencies used for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #484: use requirements.txt to formalize python deps
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #484:
URL: https://github.com/apache/arrow-datafusion/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #484: use requirements.txt to formalize python deps
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #484:
URL: https://github.com/apache/arrow-datafusion/pull/484#issuecomment-853879203
I do not quite follow: AFAIK both pip-tools and poetry are tools for Python applications, not Python libraries. For libraries, we only need to provide a `setup.py / project.toml`, which madurin does for us. I.e. the `install_requires` is [here](https://github.com/apache/arrow-datafusion/blob/master/python/Cargo.toml#L41).
AFAI understand this PR is only concerned with the dependencies used for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org