You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/02/24 01:42:58 UTC

Review Request: Simplified Future::then(_Bind) implementations.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9570/
-----------------------------------------------------------

Review request for mesos, Vinod Kone and Ben Mahler.


Description
-------

See summary.


Diffs
-----

  third_party/libprocess/include/process/future.hpp 939936720e6cda2a23ac7974311e1c4d93ea5791 

Diff: https://reviews.apache.org/r/9570/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request: Simplified Future::then(_Bind) implementations.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9570/
-----------------------------------------------------------

(Updated Feb. 24, 2013, 5:01 a.m.)


Review request for mesos, Vinod Kone and Ben Mahler.


Changes
-------

Even more simplification and tracked down and fixed places where we weren't able to directly call '.then(bind(...))'.


Description
-------

See summary.


Diffs (updated)
-----

  src/files/files.cpp 84082ce6dab6c70bb21cd290119cbdd0169be29d 
  src/state/state.hpp a0f5d75cf1bad325ab0b3c53f0d05825e211ab5f 
  third_party/libprocess/include/process/future.hpp 939936720e6cda2a23ac7974311e1c4d93ea5791 
  third_party/libprocess/src/process.cpp 878f2e866bcff8ecd743f16b1fd6f211bc5bf78a 

Diff: https://reviews.apache.org/r/9570/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request: Simplified Future::then(_Bind) implementations.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9570/#review16995
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Feb. 24, 2013, 12:42 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9570/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2013, 12:42 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/include/process/future.hpp 939936720e6cda2a23ac7974311e1c4d93ea5791 
> 
> Diff: https://reviews.apache.org/r/9570/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>