You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/27 15:56:04 UTC

[GitHub] [arrow] nealrichardson commented on a diff in pull request #13014: ARROW-16374: [R] [C++] skip another snappy test during sanitizer runs

nealrichardson commented on code in PR #13014:
URL: https://github.com/apache/arrow/pull/13014#discussion_r859970907


##########
r/tests/testthat/test-parquet.R:
##########
@@ -197,6 +197,8 @@ test_that("Maps are preserved when writing/reading from Parquet", {
 })
 
 test_that("read_parquet() and write_parquet() accept connection objects", {
+  skip_if_not_available("snappy")

Review Comment:
   The other way to do this would be to specify no compression in write_parquet(). That plus a comment explaining why is probably clearer since `skip_if_not_available("snappy")` isn't actually what's happening (snappy is available in the build but the function still skips on linux devel to avoid sanitizers)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org