You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/04/18 08:12:07 UTC
[GitHub] [zeppelin] jasmine-song opened a new pull request, #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
jasmine-song opened a new pull request, #4361:
URL: https://github.com/apache/zeppelin/pull/4361
### What is this PR for?
When use the SQL statement in paragraph, some keywords are not highlighted
The reason is new web ui code bug(zeppeline-web-angular), front-end send the parameter is 'magic', but back-end
receive the parameter is paragraphText, or else catch, don't return editsetting
This PR modify the correct parameter
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-5682
### How should this be tested?
* CI passed
### Screenshots (if appropriate)
the back-end code is
` public void getEditorSetting(String noteId,
String paragraphText,
ServiceContext context,
ServiceCallback<Map<String, Object>> callback) throws IOException {
notebook.processNote(noteId,
note -> {
if (note == null) {
callback.onFailure(new NoteNotFoundException(noteId), context);
}
try {
Map<String, Object> settings = notebook.getInterpreterSettingManager().
getEditorSetting(paragraphText, noteId);
callback.onSuccess(settings, context);
} catch (Exception e) {
callback.onFailure(new IOException("Fail to getEditorSetting", e), context);
}
return null;
});
}`
### Questions:
* Does the licenses files need to update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4361:
URL: https://github.com/apache/zeppelin/pull/4361#issuecomment-1101283047
Is t his PR related to a new UI only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
Posted by GitBox <gi...@apache.org>.
zjffdu commented on PR #4361:
URL: https://github.com/apache/zeppelin/pull/4361#issuecomment-1107965581
@jasmine-song Could you rebase your PR? CI issue is fixed recenlty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
URL: https://github.com/apache/zeppelin/pull/4361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
Posted by GitBox <gi...@apache.org>.
Reamer commented on code in PR #4361:
URL: https://github.com/apache/zeppelin/pull/4361#discussion_r852649523
##########
zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts:
##########
@@ -160,7 +160,7 @@ export enum OP {
/**
* [c-s]
* ask paragraph editor setting
- * @param magic magic keyword written in paragraph
+ * @param paragraphText magic keyword written in paragraph
Review Comment:
Please improve this part of the documentation.
My suggestion:
```
@param paragraphId paragraph id
@param paragraphText text of the paragraph
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jasmine-song commented on a diff in pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
Posted by GitBox <gi...@apache.org>.
jasmine-song commented on code in PR #4361:
URL: https://github.com/apache/zeppelin/pull/4361#discussion_r852698712
##########
zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts:
##########
@@ -160,7 +160,7 @@ export enum OP {
/**
* [c-s]
* ask paragraph editor setting
- * @param magic magic keyword written in paragraph
+ * @param paragraphText magic keyword written in paragraph
Review Comment:
ok, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
Posted by GitBox <gi...@apache.org>.
Reamer commented on code in PR #4361:
URL: https://github.com/apache/zeppelin/pull/4361#discussion_r852759014
##########
zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts:
##########
@@ -160,7 +160,7 @@ export enum OP {
/**
* [c-s]
* ask paragraph editor setting
- * @param magic magic keyword written in paragraph
+ * @param paragraphText magic keyword written in paragraph
Review Comment:
Can you please also add the documentation for the first parameter `paragraphId`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jasmine-song commented on pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
Posted by GitBox <gi...@apache.org>.
jasmine-song commented on PR #4361:
URL: https://github.com/apache/zeppelin/pull/4361#issuecomment-1101291221
> Is t his PR related to a new UI only?
yes, just zeppline-web-angular
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4361:
URL: https://github.com/apache/zeppelin/pull/4361#issuecomment-1101312803
Will merge it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org