You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/30 16:16:27 UTC
[jira] [Commented] (STORM-40) Turn worker GC logging and heapdump
on by default
[ https://issues.apache.org/jira/browse/STORM-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982680#comment-14982680 ]
ASF GitHub Bot commented on STORM-40:
-------------------------------------
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/835
[STORM-40] Turn worker garbage collection and heapdump on by default
Since STORM-901 worker artifacts directory just gets merged in, it provides a private place for us to turn on the garbage collection and heapdump for each worker by default.
This will greatly improve the debugging of storm.
Welcome discussion on the setting details (default gc rollover size, number of files, rwhether we want pid in the gc log file name, etc.),
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm 40
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/835.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #835
----
commit 24886eec5c45e7fd30cac804fd080360f17599a0
Author: zhuol <zh...@yahoo-inc.com>
Date: 2015-10-30T15:10:32Z
[STORM-40] Turn worker garbage collection and heapdump on by default
----
> Turn worker GC logging and heapdump on by default
> -------------------------------------------------
>
> Key: STORM-40
> URL: https://issues.apache.org/jira/browse/STORM-40
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: James Xu
> Assignee: Zhuo Liu
>
> https://github.com/nathanmarz/storm/issues/492
> This would be an update to the default worker.childopts. The logs should be configured to have a ceiling on the amount of space they use.
> -----------------------------------------------------------------------------------------------------
> hausdorff:
> What sounds like a reasonable amount of default space for logging to you?
> -----------------------------------------------------------------------------------------------------
> mrflip:
> This is what we've been using; it will use no more than 10 files of 1MB each. Most gc logging statements are on except PrintGCApplicationStoppedTime.
> worker.childopts: >-
> -Xloggc:/var/log/storm/gc-worker-%ID%.log -verbose:gc
> -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=10 -XX:GCLogFileSize=1m
> -XX:+PrintGCDetails -XX:+PrintHeapAtGC -XX:+PrintGCTimeStamps -XX:+PrintClassHistogram
> -XX:+PrintTenuringDistribution -XX:-PrintGCApplicationStoppedTime
>
> The challenge here is -Xloggc:/var/log/storm/gc-worker-%ID%.log -- how would you like the directory to be specified? I can add a new config variable, or add a new % interpolant, or default it to /tmp/gc-worker-%ID%.log.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)