You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Brett Lucey (JIRA)" <ji...@apache.org> on 2014/05/06 20:24:43 UTC
[jira] [Commented] (SOLR-2894) Implement distributed pivot faceting
[ https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990941#comment-13990941 ]
Brett Lucey commented on SOLR-2894:
-----------------------------------
I spoke with Andrew regarding the tests. The test does do some Query() testing to verify that the output of distributed and single node is the same, however further down it does to explicit testing. He said it's important that we don't use the variable number of shards in this particular because it exercises a number of specific sharding situations to ensure that we get the correct answers.
Looking at fieldsToOverRequestOn, I think you are correct. It looks like this probably could be a set. I suspect this is an artifact of multiple pass-throughs at the implementation of this feature. I will spend some time on this on Thursday to see if I can clean this area up and make it a little more straight forward.
Regarding PURPOSE_REFINE_PIVOT_FACETS: If it was truly needed, we probably could use a single purpose at a very slight cost. Keep in mind that the purposes are OR'd together, so they should happen in the same shard request. Having two different purposes allows us to call refineFacets and/or refinePivotFacets only as needed to avoid looping through the shard responses an extra time. If your comment is more to the effect that the loop in refineFacets() and refinePivotFacets() could be merged into a single loop -- that's probably true and if you feel it's a better route to go, let me know and I can work on that change.
> Implement distributed pivot faceting
> ------------------------------------
>
> Key: SOLR-2894
> URL: https://issues.apache.org/jira/browse/SOLR-2894
> Project: Solr
> Issue Type: Improvement
> Reporter: Erik Hatcher
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-2894-reworked.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, dateToObject.patch
>
>
> Following up on SOLR-792, pivot faceting currently only supports undistributed mode. Distributed pivot faceting needs to be implemented.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org