You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/02/07 21:04:53 UTC
Review Request 65553: Passed `ResourceProviderInfo` to disk profile
adaptor modules.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65553/
-----------------------------------------------------------
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510
Repository: mesos
Description
-------
Passed `ResourceProviderInfo` to disk profile adaptor modules.
Diffs
-----
include/mesos/resource_provider/storage/disk_profile.hpp d1a522ad23a7d8a53d5c57e9d4191e1e7652f0c8
src/resource_provider/storage/disk_profile.cpp 053fb7ac0857cbd1c57e3d75f1445ac6f083852b
src/resource_provider/storage/provider.cpp 604cadff20a6156639db10a28a180e53a959ff29
src/resource_provider/storage/uri_disk_profile.hpp 2f4fc7cededeb41afe329e1315569e097b1a60f9
src/resource_provider/storage/uri_disk_profile.cpp 7372b290d4fc3e45dc83fb3dd759150d08b7541f
Diff: https://reviews.apache.org/r/65553/diff/1/
Testing
-------
Tests done later in chain
Thanks,
Chun-Hung Hsiao
Re: Review Request 65553: Passed `ResourceProviderInfo` to disk
profile adaptor modules.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65553/
-----------------------------------------------------------
(Updated Feb. 8, 2018, 10:22 p.m.)
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Changes
-------
Addressed Jie's comment.
Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510
Repository: mesos
Description
-------
Passed `ResourceProviderInfo` to disk profile adaptor modules.
Diffs (updated)
-----
include/mesos/resource_provider/storage/disk_profile.hpp d1a522ad23a7d8a53d5c57e9d4191e1e7652f0c8
src/resource_provider/storage/disk_profile.cpp 053fb7ac0857cbd1c57e3d75f1445ac6f083852b
src/resource_provider/storage/provider.cpp 786a0cecd66e07556434a8e00712ffd5f31189b2
src/resource_provider/storage/uri_disk_profile.hpp 2f4fc7cededeb41afe329e1315569e097b1a60f9
src/resource_provider/storage/uri_disk_profile.cpp 7372b290d4fc3e45dc83fb3dd759150d08b7541f
Diff: https://reviews.apache.org/r/65553/diff/2/
Changes: https://reviews.apache.org/r/65553/diff/1-2/
Testing
-------
Tests done in the next patch in chain.
Thanks,
Chun-Hung Hsiao
Re: Review Request 65553: Passed `ResourceProviderInfo` to disk
profile adaptor modules.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65553/#review197097
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/resource_provider/storage/disk_profile.hpp
Lines 24 (patched)
<https://reviews.apache.org/r/65553/#comment277209>
Can you move this down after csi/spec.hpp? otherwise, you should move csi/spec.hpp up.
- Jie Yu
On Feb. 7, 2018, 9:04 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65553/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 9:04 p.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Passed `ResourceProviderInfo` to disk profile adaptor modules.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile.hpp d1a522ad23a7d8a53d5c57e9d4191e1e7652f0c8
> src/resource_provider/storage/disk_profile.cpp 053fb7ac0857cbd1c57e3d75f1445ac6f083852b
> src/resource_provider/storage/provider.cpp 604cadff20a6156639db10a28a180e53a959ff29
> src/resource_provider/storage/uri_disk_profile.hpp 2f4fc7cededeb41afe329e1315569e097b1a60f9
> src/resource_provider/storage/uri_disk_profile.cpp 7372b290d4fc3e45dc83fb3dd759150d08b7541f
>
>
> Diff: https://reviews.apache.org/r/65553/diff/1/
>
>
> Testing
> -------
>
> Tests done in the next patch in chain.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>