You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by marcaurele <gi...@git.apache.org> on 2016/11/11 08:34:12 UTC
[GitHub] cloudstack pull request #1760: CLOUDSTACK-9593: userdata: enforce data is a ...
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1760
CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters
Python base64 requires that the string is a multiple of 4 characters but
the Apache codec does not. RFC says is not mandatory but the data should
not fail the VR script (vmdata.py).
Signed-off-by: Marc-Aur�le Brothier <m...@brothier.org>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/exoscale/cloudstack fix/CLOUDSTACK-9593
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1760.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1760
----
commit 9575195c01ddd8079f3fdacf5712071db14d5207
Author: Marc-Aur�le Brothier <m...@brothier.org>
Date: 2016-11-11T07:53:41Z
userdata: enforce data is a multiple of 4 characters
Python base64 requires that the string is a multiple of 4 characters but
the Apache codec does not. RFC says is not mandatory but the data should
not fail the VR script (vmdata.py).
Signed-off-by: Marc-Aur�le Brothier <m...@brothier.org>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1760
@marcaurele can you check why the Travis run failed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...
Posted by marcaurele <gi...@git.apache.org>.
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1760
@rhtyd the SQL function I'm using to fix current user data in the database is not present in MySQL 5.5, but only in 5.6 (TO_BASE64, FROM_BASE64). I have to find a workaround, either in SQL or in Java to fix previous data.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...
Posted by marcaurele <gi...@git.apache.org>.
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1760
@jburwell done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1760
@marcaurele this change looks a good check to add to LTS to as well. Could you please change the base branch to 4.9? Once you do, I will kick regression tests across all hypervisors in order to merge the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...
Posted by marcaurele <gi...@git.apache.org>.
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1760
right, I forgot about the match required with the version in the pom. I thought I should prepare the stuff for the next 4.9.x release but that cannot work unless the pom files are updated too. I will just move the code inside Upgrade490to4910.java to Upgrade4910to4920.java when it's available.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...
Posted by marcaurele <gi...@git.apache.org>.
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1760
@rhtyd The DB update class for the DatabaseUpgradeChecker doesn't work on Travis. Is there something I'm doing wrong, or missed something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...
Posted by cloudmonger <gi...@git.apache.org>.
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1760
### ACS CI BVT Run
**Sumarry:**
Build Number 466
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=1
Skipped=7
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_routers_network_ops.py
* test_03_RVR_Network_check_router_state Failed
**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1760
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1760
@marcaurele an upgrade path such as `Upgrade4910to4920` would only work if your destination/final version is 4.9.2.0, have a look at the db upgrade checker workflow and you'll see how to trigger your changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...
Posted by marcaurele <gi...@git.apache.org>.
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1760
I changed the code to make it resilient to incorrect data that are already in the database. Moreover, instead of throwing an error when the padding is not present, it appends it. I think it's a better solution. I'll squash it when it's an accepted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---