You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by bruno-roustant <gi...@git.apache.org> on 2018/05/31 16:10:47 UTC
[GitHub] lucene-solr pull request #390: Refactor QueryElevationComponent to prepare q...
GitHub user bruno-roustant opened a pull request:
https://github.com/apache/lucene-solr/pull/390
Refactor QueryElevationComponent to prepare query subset matching [SOLR-11865]
See comments in https://issues.apache.org/jira/browse/SOLR-11865
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bruno-roustant/lucene-solr QueryElevationComponent
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/390.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #390
----
commit 5a6290359c0e12f2372c8470de636796928921cc
Author: broustant <br...@...>
Date: 2018-01-12T17:03:26Z
Refactor QueryElevationComponent to introduce ElevationProvider
- Refactor to introduce ElevationProvider. The current full-query match policy becomes a default simple MapElevationProvider. It can be replaced by a more efficient provider in the future, or replaced by an extending class.
- Add overridable methods to handle exceptions during the component initialization.
- Add overridable methods to provide the default values for config properties.
- No functional change beyond refactoring.
- Adapt unit test.
commit e9f53315ef0dc230280e93f868055183aa09abb6
Author: broustant <br...@...>
Date: 2018-03-30T12:04:43Z
Refactor QueryElevationComponent after review
commit 0bad4c66cf4ce89bc6cca3a7e631c20b23c500c4
Author: broustant <br...@...>
Date: 2018-04-04T15:51:03Z
Remove exception handlers and refactor getBoostDocs
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #390: Refactor QueryElevationComponent to prepare query su...
Posted by dsmiley <gi...@git.apache.org>.
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/390
I sent a PR to your PR yesterday. Assuming it's okay, please commit that to your feature branch and it'll show up here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #390: Refactor QueryElevationComponent to prepare query su...
Posted by bruno-roustant <gi...@git.apache.org>.
Github user bruno-roustant commented on the issue:
https://github.com/apache/lucene-solr/pull/390
@dsmiley here is the PR for QueryElevationComponent.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org