You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/03/19 15:10:57 UTC

[PR] GH-40670: [C++][FS][Azure] Add support for reading user defined metadata [arrow]

kou opened a new pull request, #40671:
URL: https://github.com/apache/arrow/pull/40671

   ### Rationale for this change
   
   Users may want to set user defined metadata and/or properties such as `Content-Type`.
   
   ### What changes are included in this PR?
   
   * Write user defined metadata.
   * But the following metadata are written as properties:
     * `Content-Type`
     * `Content-Encoding`
     * `Content-Language`
     * `Content-Disposition`
     * `Cache-Control`
   * The following metadata is ignored because corresponding properties are auto generated:
     * `Content-Hash`
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   Yes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-40670: [C++][FS][Azure] Add support for reading user defined metadata [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #40671:
URL: https://github.com/apache/arrow/pull/40671#issuecomment-2007454158

   @Tom-Newton @felipecrv What do you think about this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-40026: [C++][FS][Azure] Add support for reading user defined metadata [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #40671:
URL: https://github.com/apache/arrow/pull/40671#issuecomment-2009572721

   Oh, I didn't notice that this is related to #40057. (I haven't read #40057 carefully, sorry.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-40026: [C++][FS][Azure] Add support for reading user defined metadata [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #40671:
URL: https://github.com/apache/arrow/pull/40671#issuecomment-2013738870

   I'll merge this in a few days if nobody objects this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-40026: [C++][FS][Azure] Add support for reading user defined metadata [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #40671:
URL: https://github.com/apache/arrow/pull/40671#issuecomment-2016614800

   After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit fa36cde1105c8c82ef6407cb991b83d1ca67258a.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/23016783460) has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-40026: [C++][FS][Azure] Add support for reading user defined metadata [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40671:
URL: https://github.com/apache/arrow/pull/40671#issuecomment-2009561010

   :warning: GitHub issue #40026 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-40026: [C++][FS][Azure] Add support for reading user defined metadata [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #40671:
URL: https://github.com/apache/arrow/pull/40671


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-40670: [C++][FS][Azure] Add support for reading user defined metadata [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40671:
URL: https://github.com/apache/arrow/pull/40671#issuecomment-2007454662

   :warning: GitHub issue #40670 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org