You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/09/19 20:40:23 UTC

[GitHub] [thrift] 2DSharp edited a comment on pull request #1859: THRIFT-4942: Generated fields privatized; add getters/setters

2DSharp edited a comment on pull request #1859:
URL: https://github.com/apache/thrift/pull/1859#issuecomment-695353966


   @Jens-G I agree with the breaking change argument. Then just leaving the fields public as-is rather than making them private should do, I suppose?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org