You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by bc...@apache.org on 2017/05/11 20:20:53 UTC
[trafficserver] branch master updated: coverity 1196481:
Uninitialized scalar field
This is an automated email from the ASF dual-hosted git repository.
bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push:
new ece8e70 coverity 1196481: Uninitialized scalar field
ece8e70 is described below
commit ece8e70601994ff7d095e4d1c1973483feb7b7ca
Author: Bryan Call <bc...@apache.org>
AuthorDate: Thu May 11 14:32:43 2017 -0400
coverity 1196481: Uninitialized scalar field
---
proxy/http/HttpBodyFactory.cc | 7 -------
proxy/http/HttpBodyFactory.h | 14 +++++++-------
2 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/proxy/http/HttpBodyFactory.cc b/proxy/http/HttpBodyFactory.cc
index bbc4835..13af659 100644
--- a/proxy/http/HttpBodyFactory.cc
+++ b/proxy/http/HttpBodyFactory.cc
@@ -334,15 +334,8 @@ HttpBodyFactory::HttpBodyFactory()
////////////////////////////////////
// initialize first-time defaults //
////////////////////////////////////
-
- magic = HTTP_BODY_FACTORY_MAGIC;
ink_mutex_init(&mutex, "HttpBodyFactory::lock");
- table_of_sets = nullptr;
- enable_customizations = 0;
- enable_logging = true;
- callbacks_established = false;
-
//////////////////////////////////////////////////////
// set up management configuration-change callbacks //
//////////////////////////////////////////////////////
diff --git a/proxy/http/HttpBodyFactory.h b/proxy/http/HttpBodyFactory.h
index 126417a..3616286 100644
--- a/proxy/http/HttpBodyFactory.h
+++ b/proxy/http/HttpBodyFactory.h
@@ -224,17 +224,17 @@ private:
/////////////////////////////////////
// manager configuration variables //
/////////////////////////////////////
- int enable_customizations; // 0:no custom,1:custom,2:language-targeted
- bool enable_logging; // the user wants body factory logging
- int response_suppression_mode; // when to suppress responses
+ int enable_customizations = 0; // 0:no custom,1:custom,2:language-targeted
+ bool enable_logging = true; // the user wants body factory logging
+ int response_suppression_mode = 0; // when to suppress responses
////////////////////
// internal state //
////////////////////
- unsigned int magic; // magic for sanity checks/debugging
- ink_mutex mutex; // prevents reconfig/read races
- bool callbacks_established; // all config variables present
- RawHashTable *table_of_sets; // sets of template hash tables
+ unsigned int magic = HTTP_BODY_FACTORY_MAGIC; // magic for sanity checks/debugging
+ ink_mutex mutex; // prevents reconfig/read races
+ bool callbacks_established = false; // all config variables present
+ RawHashTable *table_of_sets = nullptr; // sets of template hash tables
};
#endif
--
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].