You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Giovanni Matteo Fumarola (JIRA)" <ji...@apache.org> on 2018/05/03 00:08:00 UTC

[jira] [Commented] (YARN-8163) Add support for Node Labels in opportunistic scheduling.

    [ https://issues.apache.org/jira/browse/YARN-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461758#comment-16461758 ] 

Giovanni Matteo Fumarola commented on YARN-8163:
------------------------------------------------

Thanks [~abmodi] .  Thanks for the patch.

Few comments:
 * _RemoteNodePBImpl#getNodePartition_ should return null and not an empty string.
 * nodePartition in _yarn_server_common_service_protos_ should be node_partition.
 * In _OpportunisticContainerAllocatorAMService#allocate_ _partitionedAsks.getOpportunistic()_ can be null. Please add null pointer check.
 * Please revert the deletion on the new line in _OpportunisticContainerAllocatorAMService#handle_.
 * Add comments on the jUnit.

> Add support for Node Labels in opportunistic scheduling.
> --------------------------------------------------------
>
>                 Key: YARN-8163
>                 URL: https://issues.apache.org/jira/browse/YARN-8163
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Abhishek Modi
>            Assignee: Abhishek Modi
>            Priority: Major
>         Attachments: YARN-8163.002.patch, YARN-8163.patch
>
>
> Currently, the Opportunistic Scheduler doesn't honor node labels constraints and schedule containers based on locality and load constraints. This Jira is to add support in opportunistic scheduling to honor node labels in resource requests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org