[GitHub] [beam] damccorm commented on a diff in pull request #22131: TensorRT Initial commit

[GitBox <gi...@apache.org>]

damccorm commented on code in PR #22131:
URL: https://github.com/apache/beam/pull/22131#discussion_r972416730


##########
sdks/python/test-suites/dataflow/common.gradle:
##########
@@ -364,3 +364,38 @@ task validatesContainer() {
     }
   }
 }
+
+def tensorRTTests = tasks.create("tensorRTtests") {
+  dependsOn 'installGcpTest'
+  dependsOn ':sdks:python:sdist'
+ doLast {
+  def testOpts = basicPytestOpts
+  def argMap = [
+    "runner": "DataflowRunner",
+    "machine_type":"n1-standard-4",
+    "sdk_container_image": "us.gcr.io/apache-beam-testing/python-postcommit-it/tensor_rt:latest",

Review Comment:
   Do we do this for any other tests yet/do we have a pattern we can follow? If not, I'd probably vote we put it in a `test-suites/dataflow/containers` directory and add a small README in that folder that describes that it holds images used to run Dataflow tests. That way we have a reusable pattern for similar tests in the future.
   
   Also btw, I tested the current implementation and it all worked so we should be good to merge this once the Dockerfile is in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org