[jira] [Commented] (WICKET-6042) Implementation of ExternalImage component

["Tobias Soloschenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-6042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031471#comment-15031471 ] 

Tobias Soloschenko commented on WICKET-6042:
--------------------------------------------

As of the mailing list Sebastien checked the implementation and noticed that the code would be smaller if we separate the srcSet / src model. I just explained that the intention was to get all Models via getDefaultModel / getDefaultModelObject of WebComponent.

I think it is time to create a PR to be reviewed.

I will do so later in the evening.

> Implementation of ExternalImage component
> -----------------------------------------
>
>                 Key: WICKET-6042
>                 URL: https://issues.apache.org/jira/browse/WICKET-6042
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 7.1.0, 8.0.0-M1
>            Reporter: Tobias Soloschenko
>            Assignee: Tobias Soloschenko
>              Labels: features
>
> Like in the MediaComponent - Video for example (https://ci.apache.org/projects/wicket/apidocs/7.x/org/apache/wicket/markup/html/media/video/Video.html) the Image should be able to be configured with a String placed into the src attribute.
> Possible constructor to be used for that:
> Image(String id, IModel<?> model, String... srcs) 
> As of comments the requirement changed a bit and a new implementation "ExternalImage" is the target of this ticket:
> http://apache-wicket.1842946.n4.nabble.com/Image-based-on-external-url-model-object-tt4672692.html#none



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)