You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "EricJoy2048 (via GitHub)" <gi...@apache.org> on 2023/01/31 12:43:32 UTC
[GitHub] [incubator-seatunnel] EricJoy2048 opened a new issue, #4021: [Feature][API] Add Key Features enum for Source and Sink connector
EricJoy2048 opened a new issue, #4021:
URL: https://github.com/apache/incubator-seatunnel/issues/4021
### Search before asking
- [X] I had searched in the [feature](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22) and found no similar feature requirement.
### Description
At present, the key features supported by source and sink are only described through documents, and I think there are often errors in the documents. Is it better for us to enumerate the Key Features of Source and Sink, and then add an interface in the factory of the connector so that the connector can return the features it supports?
We now support run with savepoint, but the program does not know whether a job can be retransmitted at a breakpoint. If our Source and Sink can tell the framework layer whether they support exactly-once, then the framework layer can know whether the job can be continued at break points (if both source and Sink support exactly-once, we think the job supports continued at break points).
### Usage Scenario
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on issue #4021: [Feature][API] Add Key Features enum for Source and Sink connector
Posted by "ashulin (via GitHub)" <gi...@apache.org>.
ashulin commented on issue #4021:
URL: https://github.com/apache/incubator-seatunnel/issues/4021#issuecomment-1410344682
I agree with @hailin0 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] github-actions[bot] commented on issue #4021: [Feature][API] Add Key Features enum for Source and Sink connector
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4021:
URL: https://github.com/apache/incubator-seatunnel/issues/4021#issuecomment-1465057464
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on issue #4021: [Feature][API] Add Key Features enum for Source and Sink connector
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on issue #4021:
URL: https://github.com/apache/incubator-seatunnel/issues/4021#issuecomment-1410579821
If it's just an empty interface tag, I think the annotation is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on issue #4021: [Feature][API] Add Key Features enum for Source and Sink connector
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on issue #4021:
URL: https://github.com/apache/incubator-seatunnel/issues/4021#issuecomment-1410304057
example
Add interface
```java
public interface SupportExctlyOnce {
}
```
Source or Sink implement interface
```java
public class MySource implements SeaTunnelSource, SupportExctlyOnce {
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on issue #4021: [Feature][API] Add Key Features enum for Source and Sink connector
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on issue #4021:
URL: https://github.com/apache/incubator-seatunnel/issues/4021#issuecomment-1410320333
> example
>
> Add interface
>
> ```java
> public interface SupportExctlyOnce {
>
> }
> ```
>
> Source or Sink implement interface
>
> ```java
> public class MySource implements SeaTunnelSource, SupportExctlyOnce {
> }
> ```
I suggest we add key feature enum
```
public enum SourceKeyFeature {
Exactly-once,
xxxx,
xxxx
}
public enum SinkKeyFeature {
xxx,
xxx
}
```
And add method `List<SourceKeyFeature> getSupportedKeyFeatures()` to `Factory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on issue #4021: [Feature][API] Add Key Features enum for Source and Sink connector
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on issue #4021:
URL: https://github.com/apache/incubator-seatunnel/issues/4021#issuecomment-1412013193
> If it's just an empty interface tag, I think the annotation is better
In fact, these interfaces may add methods in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on issue #4021: [Feature][API] Add Key Features enum for Source and Sink connector
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on issue #4021:
URL: https://github.com/apache/incubator-seatunnel/issues/4021#issuecomment-1412012800
> I agree with @hailin0 .
Ok, I think so too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] github-actions[bot] commented on issue #4021: [Feature][API] Add Key Features enum for Source and Sink connector
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4021:
URL: https://github.com/apache/incubator-seatunnel/issues/4021#issuecomment-1454295625
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] github-actions[bot] closed issue #4021: [Feature][API] Add Key Features enum for Source and Sink connector
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4021: [Feature][API] Add Key Features enum for Source and Sink connector
URL: https://github.com/apache/incubator-seatunnel/issues/4021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org