[jira] [Commented] (GORA-472) All gora-hbase tests to be comparative

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GORA-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870043#comment-15870043 ] 

ASF GitHub Bot commented on GORA-472:
-------------------------------------

GitHub user cloudysunny14 opened a pull request:

    https://github.com/apache/gora/pull/96

    Fixed issue GORA-472

    Couldn't be deleted the column with addColumn because addColumn is Delete the specified version of the specified column.
    I think this will be a solution to GORA-472.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudysunny14/gora GORA-472

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #96
    
----
commit 76c86b960ea4e4d40e49b9c48fe865ca8e826e8e
Author: Kiyonari Harigae <la...@cloudysunny14.org>
Date:   2017-02-16T14:28:32Z

    Fixed issue GORA-472

----


> All gora-hbase tests to be comparative
> --------------------------------------
>
>                 Key: GORA-472
>                 URL: https://issues.apache.org/jira/browse/GORA-472
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: gora-hbase, testing
>            Reporter: Lewis John McGibbney
>             Fix For: 0.8
>
>
> I am starting to get a tad sad with seeing the following in sure fire reports
> {code}
> testDeleteByQueryFields(org.apache.gora.hbase.store.TestHBaseStore)  Time elapsed: 13.287 sec  <<< FAILURE!
> java.lang.AssertionError
> 	at org.junit.Assert.fail(Assert.java:92)
> 	at org.junit.Assert.assertTrue(Assert.java:43)
> 	at org.junit.Assert.assertTrue(Assert.java:54)
> 	at org.apache.gora.store.DataStoreTestUtil.assertWebPage(DataStoreTestUtil.java:740)
> {code}
> We need to start using the comparative aspect of the JUnit API, this enables us to compare the results of what we got and what we expected. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)