[GitHub] jaydoane opened a new pull request #488: Fix _local_docs endpoint

[gi...@git.apache.org]

jaydoane opened a new pull request #488: Fix _local_docs endpoint
URL: https://github.com/apache/couchdb/pull/488
 
 
   <!-- Thank you for your contribution!
        
        Please file this form by replacing markdown commentary
        tags with the text. If section needs in no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model 
        of code collaboration. Positive feedback provides by +1 from committers
        while negative by -1. The -1 also means veto and need to be addressed
        to find the consensus. Once there are no objections, PR could be merged.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info -->
   
   ## Overview
   
   This fixes the following issues with `/{db}/_local_docs` endpoint:
   
   1. Query ignores include_docs parameter
   2. Query reports incorrect total_rows value, returning total rows for non-local docs instead
   3. Query crashes with badrecord when trying to skip records, e.g. when start_key not the first local doc
   
   **This is a rebase of https://github.com/apache/couchdb-couch-mrview/pull/72 which was not merged prior to monorepo coalescence.**
   
   ## Testing recommendations
   
   Eunit tests included
   
   ## JIRA issue number
   
   COUCHDB-3337
   
   ## Related Pull Requests
   
   <!-- If your changes affects on multiple components in different 
        repositories please list here links to those pull requests.  -->
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [x] Documentation reflects the changes;
   - [x] I will not forget to update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script)
         with the correct commit hash once this PR get merged.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services