You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/10/16 23:43:12 UTC
Re: Review Request 62142: Moved GPU resource validation into common
file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62142/
-----------------------------------------------------------
(Updated Oct. 16, 2017, 4:43 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-7492
https://issues.apache.org/jira/browse/MESOS-7492
Repository: mesos
Description
-------
Both master and agent expect GPUs to be specified in whole numbers
only. This is some of the common resource validation which will
be used by the master and by the Standalone Container API.
Diffs (updated)
-----
src/common/validation.hpp c17c07d4d85bc8973578cb503d2de25975ee1d80
src/common/validation.cpp 75c73e3ec39ede08868c7b06ccf2e84b980f33cc
src/master/validation.cpp 01bc2e0ad4de0bad570453cdaafb260c61c511eb
Diff: https://reviews.apache.org/r/62142/diff/2/
Changes: https://reviews.apache.org/r/62142/diff/1-2/
Testing
-------
See later in chain.
Thanks,
Joseph Wu
Re: Review Request 62142: Moved GPU resource validation into common
file.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62142/#review188448
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Oct. 16, 2017, 11:43 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62142/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 11:43 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-7305
> https://issues.apache.org/jira/browse/MESOS-7305
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Both master and agent expect GPUs to be specified in whole numbers
> only. This is some of the common resource validation which will
> be used by the master and by the Standalone Container API.
>
>
> Diffs
> -----
>
> src/common/validation.hpp c17c07d4d85bc8973578cb503d2de25975ee1d80
> src/common/validation.cpp 75c73e3ec39ede08868c7b06ccf2e84b980f33cc
> src/master/validation.cpp 01bc2e0ad4de0bad570453cdaafb260c61c511eb
>
>
> Diff: https://reviews.apache.org/r/62142/diff/2/
>
>
> Testing
> -------
>
> See later in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>