You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> on 2012/10/12 23:38:23 UTC

Review Request: Encode URI during vmware cluster discovery

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7571/
-----------------------------------------------------------

Review request for cloudstack and Kelven Yang.


Description
-------

Encoding URI during vmware cluster discovery was missed out in one place, fixing it.


This addresses bug CLOUDSTACK-333.


Diffs
-----

  server/src/com/cloud/storage/StorageManagerImpl.java 7ec50f9 

Diff: https://reviews.apache.org/r/7571/diff/


Testing
-------


Thanks,

Venkata Siva Vijayendra Bhamidipati


Re: Review Request: Encode URI during vmware cluster discovery

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7571/#review12436
-----------------------------------------------------------

Ship it!


Ship It!

- Sateesh Chodapuneedi


On Oct. 12, 2012, 9:38 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7571/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2012, 9:38 p.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Encoding URI during vmware cluster discovery was missed out in one place, fixing it.
> 
> 
> This addresses bug CLOUDSTACK-333.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/StorageManagerImpl.java 7ec50f9 
> 
> Diff: https://reviews.apache.org/r/7571/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>


Re: Review Request: Encode URI during vmware cluster discovery

Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7571/#review14490
-----------------------------------------------------------

Ship it!


Applied on master

commit 8ced7da733f8f3e9402495a239f037804ebea2a3
Author: Vijayendra Bhamidipati <vi...@citrix.com>
Date:   Fri Oct 12 17:33:36 2012 -0400

    CLOUDSTACK-333: When Datacenter name in VCenter has spaces Primary Storage (VMFS) discovery will fail
    
    Description:
    
        Missed encoding of URI when discovering ESX cluster in vCenter.
    
        Signed-off-by: Vijayendra Bhamidipati <vi...@citrix.com>


- Prasanna Santhanam


On Oct. 12, 2012, 9:38 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7571/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2012, 9:38 p.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Encoding URI during vmware cluster discovery was missed out in one place, fixing it.
> 
> 
> This addresses bug CLOUDSTACK-333.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/StorageManagerImpl.java 7ec50f9 
> 
> Diff: https://reviews.apache.org/r/7571/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>