You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/08/25 15:39:12 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages

dongjoon-hyun commented on code in PR #42674:
URL: https://github.com/apache/spark/pull/42674#discussion_r1305821221


##########
core/src/main/scala/org/apache/spark/ui/UIUtils.scala:
##########
@@ -709,7 +708,7 @@ private[spark] object UIUtils extends Logging {
 
   private final val ERROR_CLASS_REGEX = """\[(?<errorClass>[A-Z][A-Z_.]+[A-Z])]""".r
 
-  private def errorSummary(errorMessage: String): (String, Boolean) = {
+  def errorSummary(errorMessage: String): (String, Boolean) = {

Review Comment:
   Given that we have `private[spark] object UIUtils`, this looks okay.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org