[GitHub] [incubator-superset] kristw commented on a change in pull request #8166: [feature][dashboard] Show/hide filter indicator on the applicable charts when filter options are open/close

[GitBox <gi...@apache.org>]

kristw commented on a change in pull request #8166: [feature][dashboard] Show/hide filter indicator on the applicable charts when filter options are open/close
URL: https://github.com/apache/incubator-superset/pull/8166#discussion_r321410661
 
 

 ##########
 File path: superset/assets/src/visualizations/FilterBox/transformProps.js
 ##########
 @@ -53,6 +53,8 @@ export default function transformProps(chartProps) {
     filtersFields,
     instantFiltering,
     onChange: onAddFilter,
+    onFilterMenuOpen: hooks.onFilterMenuOpen,
 
 Review comment:
   You could destructure these two handlers along with `onAddFilter` on line 30 above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org