You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/01 07:28:46 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34489: [SPARK-37210][SQL] Write to static partition in dynamic write mode

dongjoon-hyun commented on a change in pull request #34489:
URL: https://github.com/apache/spark/pull/34489#discussion_r759917283



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHiveSingleton.scala
##########
@@ -27,9 +27,9 @@ import org.apache.spark.sql.hive.client.HiveClient
 
 trait TestHiveSingleton extends SparkFunSuite with BeforeAndAfterAll {
   override protected val enableAutoThreadAudit = false
-  protected val spark: SparkSession = TestHive.sparkSession
-  protected val hiveContext: TestHiveContext = TestHive
-  protected val hiveClient: HiveClient =
+  protected lazy val spark: SparkSession = TestHive.sparkSession
+  protected lazy val hiveContext: TestHiveContext = TestHive
+  protected lazy val hiveClient: HiveClient =

Review comment:
       Could you add some comment to explain why these `lazy` are required, please?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org