You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/23 22:10:02 UTC

[GitHub] [arrow-rs] tustvold edited a comment on pull request #1225: Improve MutableArrayData Null Handling (#1224) (#1230)

tustvold edited a comment on pull request #1225:
URL: https://github.com/apache/arrow-rs/pull/1225#issuecomment-1019576573


   I've pushed a first cut of trying to clarify the null handling in MutableArrayData. This PR also now fixes #1230. It is worth highlighting that this is an API change. In particular until #1234 is merged the tests will fail.
   
   I also changed to using BooleanBufferBuilder instead of MutableBuffer directly, which gives an extra sanity check and also avoids some code duplication. This required making `BooleanBufferBuilder::append_packed_range` return the number of `0` bits set. This API is relatively new, added in #1039, but this still is technically a breaking change.
   
   I will take another look at this with fresh eyes in the morning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org