You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/24 22:59:42 UTC

[GitHub] [geode] bschuchardt commented on a change in pull request #6051: GEODE-8862: Uses another thread to process DistributedCacheOperation

bschuchardt commented on a change in pull request #6051:
URL: https://github.com/apache/geode/pull/6051#discussion_r582366653



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/DistributedCacheOperation.java
##########
@@ -1107,6 +1107,10 @@ protected void process(final ClusterDistributionManager dm) {
 
         final LocalRegion lclRgn = getLocalRegionForProcessing(dm);
         sendReply = false;
+        if (lclRgn != null && lclRgn.getScope().isDistributedNoAck()) {
+          dm.getExecutors().getWaitingThreadPool().execute(() -> basicProcess(dm, lclRgn));

Review comment:
       this previously caught CancelException and set this.closed=true.  That's no longer being done for distributed-no-ack regions.  Why is that okay?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org