You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2017/01/06 10:46:37 UTC

Review Request 55261: Reconfigure after adding/deleting ZooKeeper Server is not performed if Atlas is installed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55261/
-----------------------------------------------------------

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-19400
    https://issues.apache.org/jira/browse/AMBARI-19400


Repository: ambari


Description
-------

No required configs changes are made after adding or deleting ZooKeeper Server to host when Atlas is installed on cluster.
JS error is thrown after user confirms adding or deleting ZooKeeper Server:
```
Uncaught TypeError: Cannot read property 'tag' of undefined
```


Diffs
-----

  ambari-web/app/controllers/main/host/details.js 7df2c4e 
  ambari-web/test/controllers/main/host/details_test.js 03dadc6 

Diff: https://reviews.apache.org/r/55261/diff/


Testing
-------

20275 tests complete (23 seconds)
  153 tests pending


Thanks,

Andriy Babiichuk


Re: Review Request 55261: Reconfigure after adding/deleting ZooKeeper Server is not performed if Atlas is installed

Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55261/#review160698
-----------------------------------------------------------


Ship it!




Ship It!

- Andrii Tkach


On Jan. 6, 2017, 10:46 a.m., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55261/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2017, 10:46 a.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-19400
>     https://issues.apache.org/jira/browse/AMBARI-19400
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> No required configs changes are made after adding or deleting ZooKeeper Server to host when Atlas is installed on cluster.
> JS error is thrown after user confirms adding or deleting ZooKeeper Server:
> ```
> Uncaught TypeError: Cannot read property 'tag' of undefined
> ```
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/host/details.js 7df2c4e 
>   ambari-web/test/controllers/main/host/details_test.js 03dadc6 
> 
> Diff: https://reviews.apache.org/r/55261/diff/
> 
> 
> Testing
> -------
> 
> 20275 tests complete (23 seconds)
>   153 tests pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>