You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "jrhenderson1988 (via GitHub)" <gi...@apache.org> on 2023/08/11 18:00:12 UTC

[GitHub] [solr] jrhenderson1988 opened a new pull request, #1837: SOLR-16928: Add missing unit tests for RegexFileFilter and StrUtils.toLower

jrhenderson1988 opened a new pull request, #1837:
URL: https://github.com/apache/solr/pull/1837

   https://issues.apache.org/jira/browse/SOLR-16928
   
   <!--
   _(If you are a project committer then you may remove some/all of the following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system for Solr:
   
   * https://issues.apache.org/jira/projects/SOLR
   
   For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. 
   To create a Jira issue, you will need to create an account there first.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * SOLR-####: <short description of problem or changes>
   
   SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   Please provide a short description of the changes you're making with this pull request.
   
   # Solution
   
   Please provide a short description of the approach taken to implement your solution.
   
   # Tests
   
   Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request title.
   - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [ ] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] mkhludnev commented on pull request #1837: SOLR-16928: Add missing unit tests for RegexFileFilter and StrUtils.toLower

Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on PR #1837:
URL: https://github.com/apache/solr/pull/1837#issuecomment-1676096344

   Yeah, @jrhenderson1988 `SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull` have failed. Kicked test off again. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] jrhenderson1988 commented on pull request #1837: SOLR-16928: Add missing unit tests for RegexFileFilter and StrUtils.toLower

Posted by "jrhenderson1988 (via GitHub)" <gi...@apache.org>.
jrhenderson1988 commented on PR #1837:
URL: https://github.com/apache/solr/pull/1837#issuecomment-1676457599

   Sounds good! Let me know if there's anything you need from me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] jrhenderson1988 commented on pull request #1837: SOLR-16928: Add missing unit tests for RegexFileFilter and StrUtils.toLower

Posted by "jrhenderson1988 (via GitHub)" <gi...@apache.org>.
jrhenderson1988 commented on PR #1837:
URL: https://github.com/apache/solr/pull/1837#issuecomment-1676406483

   @mkhludnev Thanks for kicking off again. Looks to have passed this time.
   
   > I think, we might not mention it in CHANGES.txt. WDYT?
   
   I'm not sure that I understand. Would you like me to add something to CHANGES.txt under the 10.0.0 release, or do you think it is not necessary? Please let me know if you'd like me to add something, and I can do that. Otherwise, you can feel free to merge this PR whenever you are ready 🙂 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] mkhludnev commented on pull request #1837: SOLR-16928: Add missing unit tests for RegexFileFilter and StrUtils.toLower

Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on PR #1837:
URL: https://github.com/apache/solr/pull/1837#issuecomment-1676330502

   I think, we might not mention it in CHANGES.txt. WDYT? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] mkhludnev merged pull request #1837: SOLR-16928: Add missing unit tests for RegexFileFilter and StrUtils.toLower

Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev merged PR #1837:
URL: https://github.com/apache/solr/pull/1837


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] jrhenderson1988 commented on pull request #1837: SOLR-16928: Add missing unit tests for RegexFileFilter and StrUtils.toLower

Posted by "jrhenderson1988 (via GitHub)" <gi...@apache.org>.
jrhenderson1988 commented on PR #1837:
URL: https://github.com/apache/solr/pull/1837#issuecomment-1676068047

   @mkhludnev Thanks for approving. The build seems to have failed and I don't think it's related to my change. However, I'm unable to re-run the build. Would you be able to kick it off again, please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] mkhludnev commented on pull request #1837: SOLR-16928: Add missing unit tests for RegexFileFilter and StrUtils.toLower

Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on PR #1837:
URL: https://github.com/apache/solr/pull/1837#issuecomment-1676446514

   Thanks, Jonathon. I'm for merging and picking it into 9, without mention in CHANGES. I'm taking a pause for a while to check if there's an alternative opinion. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org